Revert "Reland "Remove other uses of SkFontMgr::RefDefault""
This reverts commit 54eaf0d92645b0f82d996c01adbe3e8eb8955425.
Reason for revert: significant tree breakage
Original change's description:
> Reland "Remove other uses of SkFontMgr::RefDefault"
>
> This reverts commit c244996e79d6ce0d523f60af2d9575206ddec5b1.
>
> Chrome fix in https://crrev.com/c/5049603
>
> Original change's description:
> > Revert "Remove other uses of SkFontMgr::RefDefault"
> >
> > This reverts commit d6cfa43b743e99a8d793bd4d69826613dab0a931.
> >
> > Reason for revert: Breaking chromium + skottie
> >
> > Original change's description:
> > > Remove other uses of SkFontMgr::RefDefault
> > >
> > > Clients of Skottie should be setting their own SkFontMgrs and not
> > > be relying on the default, so we don't need to lazily load it.
> > >
> > > SkParagraph already has a fallback fontmgr, so let's use that
> > > instead of the default.
> > >
> > > SkShaper_harfbuzz appears to only use the fontmgr for fallback,
> > > which I documented some and removed the behavior where a null
> > > fallback SkFontMgr would default to SkFontMgr::RefDefault()
> > > (it now means the empty FontMgr or "no" fallback).
> > >
> > > After this CL lands, we still need to clean up clients.
> > >
> > > Bug: b/305780908
> > > Change-Id: If7e9dd148e561303a424bca823e4d7c1bc5b9183
> > > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/779396
> > > Commit-Queue: Kevin Lubick <kjlubick@google.com>
> > > Reviewed-by: Florin Malita <fmalita@google.com>
> > > Reviewed-by: Ben Wagner <bungeman@google.com>
> >
> > Bug: b/305780908
> > Change-Id: Idb87194291108c465482eb9f6b6d496efaf51e01
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/781676
> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Auto-Submit: Kevin Lubick <kjlubick@google.com>
>
> Bug: b/305780908
> Change-Id: If07b4f4e7f4fc903ac032aafeecc9a436136c266
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/781836
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Ben Wagner <bungeman@google.com>
> Commit-Queue: Kevin Lubick <kjlubick@google.com>
Bug: b/305780908
Change-Id: Ie0c569f8abf2ce9822cdd0aee58cba648da71cdd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/782156
Auto-Submit: John Stiles <johnstiles@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
21 files changed