Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1 | #!/usr/bin/perl -w |
| 2 | # (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit) |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 3 | # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit) |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 4 | # (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc) |
| 5 | # Licensed under the terms of the GNU GPL License version 2 |
| 6 | |
| 7 | use strict; |
| 8 | |
| 9 | my $P = $0; |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 10 | $P =~ s@.*/@@g; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 11 | |
Andy Whitcroft | 6cbb2e7 | 2008-07-23 21:28:55 -0700 | [diff] [blame] | 12 | my $V = '0.20'; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 13 | |
| 14 | use Getopt::Long qw(:config no_auto_abbrev); |
| 15 | |
| 16 | my $quiet = 0; |
| 17 | my $tree = 1; |
| 18 | my $chk_signoff = 1; |
| 19 | my $chk_patch = 1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 20 | my $tst_only; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 21 | my $emacs = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 22 | my $terse = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 23 | my $file = 0; |
| 24 | my $check = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 25 | my $summary = 1; |
| 26 | my $mailback = 0; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 27 | my $summary_file = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 28 | my $root; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 29 | my %debug; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 30 | GetOptions( |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 31 | 'q|quiet+' => \$quiet, |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 32 | 'tree!' => \$tree, |
| 33 | 'signoff!' => \$chk_signoff, |
| 34 | 'patch!' => \$chk_patch, |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 35 | 'emacs!' => \$emacs, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 36 | 'terse!' => \$terse, |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 37 | 'file!' => \$file, |
| 38 | 'subjective!' => \$check, |
| 39 | 'strict!' => \$check, |
| 40 | 'root=s' => \$root, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 41 | 'summary!' => \$summary, |
| 42 | 'mailback!' => \$mailback, |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 43 | 'summary-file!' => \$summary_file, |
| 44 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 45 | 'debug=s' => \%debug, |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 46 | 'test-only=s' => \$tst_only, |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 47 | ) or exit; |
| 48 | |
| 49 | my $exit = 0; |
| 50 | |
| 51 | if ($#ARGV < 0) { |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 52 | print "usage: $P [options] patchfile\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 53 | print "version: $V\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 54 | print "options: -q => quiet\n"; |
| 55 | print " --no-tree => run without a kernel tree\n"; |
| 56 | print " --terse => one line per report\n"; |
| 57 | print " --emacs => emacs compile window format\n"; |
| 58 | print " --file => check a source file\n"; |
| 59 | print " --strict => enable more subjective tests\n"; |
| 60 | print " --root => path to the kernel tree root\n"; |
| 61 | print " --no-summary => suppress the per-file summary\n"; |
| 62 | print " --summary-file => include the filename in summary\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 63 | exit(1); |
| 64 | } |
| 65 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 66 | my $dbg_values = 0; |
| 67 | my $dbg_possible = 0; |
Andy Whitcroft | 7429c69 | 2008-07-23 21:29:06 -0700 | [diff] [blame^] | 68 | my $dbg_type = 0; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 69 | for my $key (keys %debug) { |
| 70 | eval "\${dbg_$key} = '$debug{$key}';" |
| 71 | } |
| 72 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 73 | if ($terse) { |
| 74 | $emacs = 1; |
| 75 | $quiet++; |
| 76 | } |
| 77 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 78 | if ($tree) { |
| 79 | if (defined $root) { |
| 80 | if (!top_of_kernel_tree($root)) { |
| 81 | die "$P: $root: --root does not point at a valid tree\n"; |
| 82 | } |
| 83 | } else { |
| 84 | if (top_of_kernel_tree('.')) { |
| 85 | $root = '.'; |
| 86 | } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ && |
| 87 | top_of_kernel_tree($1)) { |
| 88 | $root = $1; |
| 89 | } |
| 90 | } |
| 91 | |
| 92 | if (!defined $root) { |
| 93 | print "Must be run from the top-level dir. of a kernel tree\n"; |
| 94 | exit(2); |
| 95 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 96 | } |
| 97 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 98 | my $emitted_corrupt = 0; |
| 99 | |
| 100 | our $Ident = qr{[A-Za-z_][A-Za-z\d_]*}; |
| 101 | our $Storage = qr{extern|static|asmlinkage}; |
| 102 | our $Sparse = qr{ |
| 103 | __user| |
| 104 | __kernel| |
| 105 | __force| |
| 106 | __iomem| |
| 107 | __must_check| |
| 108 | __init_refok| |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 109 | __kprobes |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 110 | }x; |
| 111 | our $Attribute = qr{ |
| 112 | const| |
| 113 | __read_mostly| |
| 114 | __kprobes| |
| 115 | __(?:mem|cpu|dev|)(?:initdata|init) |
| 116 | }x; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 117 | our $Modifier; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 118 | our $Inline = qr{inline|__always_inline|noinline}; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 119 | our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]}; |
| 120 | our $Lval = qr{$Ident(?:$Member)*}; |
| 121 | |
| 122 | our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*}; |
| 123 | our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)}; |
| 124 | our $Operators = qr{ |
| 125 | <=|>=|==|!=| |
| 126 | =>|->|<<|>>|<|>|!|~| |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 127 | &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|% |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 128 | }x; |
| 129 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 130 | our $NonptrType; |
| 131 | our $Type; |
| 132 | our $Declare; |
| 133 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 134 | our $UTF8 = qr { |
| 135 | [\x09\x0A\x0D\x20-\x7E] # ASCII |
| 136 | | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte |
| 137 | | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs |
| 138 | | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte |
| 139 | | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates |
| 140 | | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3 |
| 141 | | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15 |
| 142 | | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16 |
| 143 | }x; |
| 144 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 145 | our @typeList = ( |
| 146 | qr{void}, |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 147 | qr{(?:unsigned\s+)?char}, |
| 148 | qr{(?:unsigned\s+)?short}, |
| 149 | qr{(?:unsigned\s+)?int}, |
| 150 | qr{(?:unsigned\s+)?long}, |
| 151 | qr{(?:unsigned\s+)?long\s+int}, |
| 152 | qr{(?:unsigned\s+)?long\s+long}, |
| 153 | qr{(?:unsigned\s+)?long\s+long\s+int}, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 154 | qr{unsigned}, |
| 155 | qr{float}, |
| 156 | qr{double}, |
| 157 | qr{bool}, |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 158 | qr{(?:__)?(?:u|s|be|le)(?:8|16|32|64)}, |
| 159 | qr{struct\s+$Ident}, |
| 160 | qr{union\s+$Ident}, |
| 161 | qr{enum\s+$Ident}, |
| 162 | qr{${Ident}_t}, |
| 163 | qr{${Ident}_handler}, |
| 164 | qr{${Ident}_handler_fn}, |
| 165 | ); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 166 | our @modifierList = ( |
| 167 | qr{fastcall}, |
| 168 | ); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 169 | |
| 170 | sub build_types { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 171 | my $mods = "(?: \n" . join("|\n ", @modifierList) . "\n)"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 172 | my $all = "(?: \n" . join("|\n ", @typeList) . "\n)"; |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 173 | $Modifier = qr{(?:$Attribute|$Sparse|$mods)}; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 174 | $NonptrType = qr{ |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 175 | (?:const\s+)? |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 176 | (?:$mods\s+)? |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 177 | (?: |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 178 | (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)| |
| 179 | (?:${all}\b) |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 180 | ) |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 181 | (?:\s+$Modifier|\s+const)* |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 182 | }x; |
| 183 | $Type = qr{ |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 184 | $NonptrType |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 185 | (?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)? |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 186 | (?:\s+$Inline|\s+$Modifier)* |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 187 | }x; |
| 188 | $Declare = qr{(?:$Storage\s+)?$Type}; |
| 189 | } |
| 190 | build_types(); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 191 | |
| 192 | $chk_signoff = 0 if ($file); |
| 193 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 194 | my @dep_includes = (); |
| 195 | my @dep_functions = (); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 196 | my $removal = "Documentation/feature-removal-schedule.txt"; |
| 197 | if ($tree && -f "$root/$removal") { |
| 198 | open(REMOVE, "<$root/$removal") || |
| 199 | die "$P: $removal: open failed - $!\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 200 | while (<REMOVE>) { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 201 | if (/^Check:\s+(.*\S)/) { |
| 202 | for my $entry (split(/[, ]+/, $1)) { |
| 203 | if ($entry =~ m@include/(.*)@) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 204 | push(@dep_includes, $1); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 205 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 206 | } elsif ($entry !~ m@/@) { |
| 207 | push(@dep_functions, $entry); |
| 208 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 209 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 210 | } |
| 211 | } |
| 212 | } |
| 213 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 214 | my @rawlines = (); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 215 | my @lines = (); |
| 216 | my $vname; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 217 | for my $filename (@ARGV) { |
| 218 | if ($file) { |
| 219 | open(FILE, "diff -u /dev/null $filename|") || |
| 220 | die "$P: $filename: diff failed - $!\n"; |
| 221 | } else { |
| 222 | open(FILE, "<$filename") || |
| 223 | die "$P: $filename: open failed - $!\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 224 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 225 | if ($filename eq '-') { |
| 226 | $vname = 'Your patch'; |
| 227 | } else { |
| 228 | $vname = $filename; |
| 229 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 230 | while (<FILE>) { |
| 231 | chomp; |
| 232 | push(@rawlines, $_); |
| 233 | } |
| 234 | close(FILE); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 235 | if (!process($filename)) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 236 | $exit = 1; |
| 237 | } |
| 238 | @rawlines = (); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 239 | @lines = (); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 240 | } |
| 241 | |
| 242 | exit($exit); |
| 243 | |
| 244 | sub top_of_kernel_tree { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 245 | my ($root) = @_; |
| 246 | |
| 247 | my @tree_check = ( |
| 248 | "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile", |
| 249 | "README", "Documentation", "arch", "include", "drivers", |
| 250 | "fs", "init", "ipc", "kernel", "lib", "scripts", |
| 251 | ); |
| 252 | |
| 253 | foreach my $check (@tree_check) { |
| 254 | if (! -e $root . '/' . $check) { |
| 255 | return 0; |
| 256 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 257 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 258 | return 1; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 259 | } |
| 260 | |
| 261 | sub expand_tabs { |
| 262 | my ($str) = @_; |
| 263 | |
| 264 | my $res = ''; |
| 265 | my $n = 0; |
| 266 | for my $c (split(//, $str)) { |
| 267 | if ($c eq "\t") { |
| 268 | $res .= ' '; |
| 269 | $n++; |
| 270 | for (; ($n % 8) != 0; $n++) { |
| 271 | $res .= ' '; |
| 272 | } |
| 273 | next; |
| 274 | } |
| 275 | $res .= $c; |
| 276 | $n++; |
| 277 | } |
| 278 | |
| 279 | return $res; |
| 280 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 281 | sub copy_spacing { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 282 | (my $res = shift) =~ tr/\t/ /c; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 283 | return $res; |
| 284 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 285 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 286 | sub line_stats { |
| 287 | my ($line) = @_; |
| 288 | |
| 289 | # Drop the diff line leader and expand tabs |
| 290 | $line =~ s/^.//; |
| 291 | $line = expand_tabs($line); |
| 292 | |
| 293 | # Pick the indent from the front of the line. |
| 294 | my ($white) = ($line =~ /^(\s*)/); |
| 295 | |
| 296 | return (length($line), length($white)); |
| 297 | } |
| 298 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 299 | my $sanitise_quote = ''; |
| 300 | |
| 301 | sub sanitise_line_reset { |
| 302 | my ($in_comment) = @_; |
| 303 | |
| 304 | if ($in_comment) { |
| 305 | $sanitise_quote = '*/'; |
| 306 | } else { |
| 307 | $sanitise_quote = ''; |
| 308 | } |
| 309 | } |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 310 | sub sanitise_line { |
| 311 | my ($line) = @_; |
| 312 | |
| 313 | my $res = ''; |
| 314 | my $l = ''; |
| 315 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 316 | my $qlen = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 317 | my $off = 0; |
| 318 | my $c; |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 319 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 320 | # Always copy over the diff marker. |
| 321 | $res = substr($line, 0, 1); |
| 322 | |
| 323 | for ($off = 1; $off < length($line); $off++) { |
| 324 | $c = substr($line, $off, 1); |
| 325 | |
| 326 | # Comments we are wacking completly including the begin |
| 327 | # and end, all to $;. |
| 328 | if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') { |
| 329 | $sanitise_quote = '*/'; |
| 330 | |
| 331 | substr($res, $off, 2, "$;$;"); |
| 332 | $off++; |
| 333 | next; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 334 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 335 | if (substr($line, $off, 2) eq '*/') { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 336 | $sanitise_quote = ''; |
| 337 | substr($res, $off, 2, "$;$;"); |
| 338 | $off++; |
| 339 | next; |
| 340 | } |
| 341 | |
| 342 | # A \ in a string means ignore the next character. |
| 343 | if (($sanitise_quote eq "'" || $sanitise_quote eq '"') && |
| 344 | $c eq "\\") { |
| 345 | substr($res, $off, 2, 'XX'); |
| 346 | $off++; |
| 347 | next; |
| 348 | } |
| 349 | # Regular quotes. |
| 350 | if ($c eq "'" || $c eq '"') { |
| 351 | if ($sanitise_quote eq '') { |
| 352 | $sanitise_quote = $c; |
| 353 | |
| 354 | substr($res, $off, 1, $c); |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 355 | next; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 356 | } elsif ($sanitise_quote eq $c) { |
| 357 | $sanitise_quote = ''; |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 358 | } |
| 359 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 360 | |
| 361 | #print "SQ:$sanitise_quote\n"; |
| 362 | if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") { |
| 363 | substr($res, $off, 1, $;); |
| 364 | } elsif ($off != 0 && $sanitise_quote && $c ne "\t") { |
| 365 | substr($res, $off, 1, 'X'); |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 366 | } else { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 367 | substr($res, $off, 1, $c); |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 368 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 369 | } |
| 370 | |
| 371 | # The pathname on a #include may be surrounded by '<' and '>'. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 372 | if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 373 | my $clean = 'X' x length($1); |
| 374 | $res =~ s@\<.*\>@<$clean>@; |
| 375 | |
| 376 | # The whole of a #error is a string. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 377 | } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 378 | my $clean = 'X' x length($1); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 379 | $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 380 | } |
| 381 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 382 | return $res; |
| 383 | } |
| 384 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 385 | sub ctx_statement_block { |
| 386 | my ($linenr, $remain, $off) = @_; |
| 387 | my $line = $linenr - 1; |
| 388 | my $blk = ''; |
| 389 | my $soff = $off; |
| 390 | my $coff = $off - 1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 391 | my $coff_set = 0; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 392 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 393 | my $loff = 0; |
| 394 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 395 | my $type = ''; |
| 396 | my $level = 0; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 397 | my $p; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 398 | my $c; |
| 399 | my $len = 0; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 400 | |
| 401 | my $remainder; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 402 | while (1) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 403 | #warn "CSB: blk<$blk> remain<$remain>\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 404 | # If we are about to drop off the end, pull in more |
| 405 | # context. |
| 406 | if ($off >= $len) { |
| 407 | for (; $remain > 0; $line++) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 408 | next if ($lines[$line] =~ /^-/); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 409 | $remain--; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 410 | $loff = $len; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 411 | $blk .= $lines[$line] . "\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 412 | $len = length($blk); |
| 413 | $line++; |
| 414 | last; |
| 415 | } |
| 416 | # Bail if there is no further context. |
| 417 | #warn "CSB: blk<$blk> off<$off> len<$len>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 418 | if ($off >= $len) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 419 | last; |
| 420 | } |
| 421 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 422 | $p = $c; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 423 | $c = substr($blk, $off, 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 424 | $remainder = substr($blk, $off); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 425 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 426 | #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 427 | # Statement ends at the ';' or a close '}' at the |
| 428 | # outermost level. |
| 429 | if ($level == 0 && $c eq ';') { |
| 430 | last; |
| 431 | } |
| 432 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 433 | # An else is really a conditional as long as its not else if |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 434 | if ($level == 0 && $coff_set == 0 && |
| 435 | (!defined($p) || $p =~ /(?:\s|\}|\+)/) && |
| 436 | $remainder =~ /^(else)(?:\s|{)/ && |
| 437 | $remainder !~ /^else\s+if\b/) { |
| 438 | $coff = $off + length($1) - 1; |
| 439 | $coff_set = 1; |
| 440 | #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n"; |
| 441 | #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 442 | } |
| 443 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 444 | if (($type eq '' || $type eq '(') && $c eq '(') { |
| 445 | $level++; |
| 446 | $type = '('; |
| 447 | } |
| 448 | if ($type eq '(' && $c eq ')') { |
| 449 | $level--; |
| 450 | $type = ($level != 0)? '(' : ''; |
| 451 | |
| 452 | if ($level == 0 && $coff < $soff) { |
| 453 | $coff = $off; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 454 | $coff_set = 1; |
| 455 | #warn "CSB: mark coff<$coff>\n"; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 456 | } |
| 457 | } |
| 458 | if (($type eq '' || $type eq '{') && $c eq '{') { |
| 459 | $level++; |
| 460 | $type = '{'; |
| 461 | } |
| 462 | if ($type eq '{' && $c eq '}') { |
| 463 | $level--; |
| 464 | $type = ($level != 0)? '{' : ''; |
| 465 | |
| 466 | if ($level == 0) { |
| 467 | last; |
| 468 | } |
| 469 | } |
| 470 | $off++; |
| 471 | } |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 472 | # We are truly at the end, so shuffle to the next line. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 473 | if ($off == $len) { |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 474 | $loff = $len + 1; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 475 | $line++; |
| 476 | $remain--; |
| 477 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 478 | |
| 479 | my $statement = substr($blk, $soff, $off - $soff + 1); |
| 480 | my $condition = substr($blk, $soff, $coff - $soff + 1); |
| 481 | |
| 482 | #warn "STATEMENT<$statement>\n"; |
| 483 | #warn "CONDITION<$condition>\n"; |
| 484 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 485 | #print "coff<$coff> soff<$off> loff<$loff>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 486 | |
| 487 | return ($statement, $condition, |
| 488 | $line, $remain + 1, $off - $loff + 1, $level); |
| 489 | } |
| 490 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 491 | sub statement_lines { |
| 492 | my ($stmt) = @_; |
| 493 | |
| 494 | # Strip the diff line prefixes and rip blank lines at start and end. |
| 495 | $stmt =~ s/(^|\n)./$1/g; |
| 496 | $stmt =~ s/^\s*//; |
| 497 | $stmt =~ s/\s*$//; |
| 498 | |
| 499 | my @stmt_lines = ($stmt =~ /\n/g); |
| 500 | |
| 501 | return $#stmt_lines + 2; |
| 502 | } |
| 503 | |
| 504 | sub statement_rawlines { |
| 505 | my ($stmt) = @_; |
| 506 | |
| 507 | my @stmt_lines = ($stmt =~ /\n/g); |
| 508 | |
| 509 | return $#stmt_lines + 2; |
| 510 | } |
| 511 | |
| 512 | sub statement_block_size { |
| 513 | my ($stmt) = @_; |
| 514 | |
| 515 | $stmt =~ s/(^|\n)./$1/g; |
| 516 | $stmt =~ s/^\s*{//; |
| 517 | $stmt =~ s/}\s*$//; |
| 518 | $stmt =~ s/^\s*//; |
| 519 | $stmt =~ s/\s*$//; |
| 520 | |
| 521 | my @stmt_lines = ($stmt =~ /\n/g); |
| 522 | my @stmt_statements = ($stmt =~ /;/g); |
| 523 | |
| 524 | my $stmt_lines = $#stmt_lines + 2; |
| 525 | my $stmt_statements = $#stmt_statements + 1; |
| 526 | |
| 527 | if ($stmt_lines > $stmt_statements) { |
| 528 | return $stmt_lines; |
| 529 | } else { |
| 530 | return $stmt_statements; |
| 531 | } |
| 532 | } |
| 533 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 534 | sub ctx_statement_full { |
| 535 | my ($linenr, $remain, $off) = @_; |
| 536 | my ($statement, $condition, $level); |
| 537 | |
| 538 | my (@chunks); |
| 539 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 540 | # Grab the first conditional/block pair. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 541 | ($statement, $condition, $linenr, $remain, $off, $level) = |
| 542 | ctx_statement_block($linenr, $remain, $off); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 543 | #print "F: c<$condition> s<$statement> remain<$remain>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 544 | push(@chunks, [ $condition, $statement ]); |
| 545 | if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) { |
| 546 | return ($level, $linenr, @chunks); |
| 547 | } |
| 548 | |
| 549 | # Pull in the following conditional/block pairs and see if they |
| 550 | # could continue the statement. |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 551 | for (;;) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 552 | ($statement, $condition, $linenr, $remain, $off, $level) = |
| 553 | ctx_statement_block($linenr, $remain, $off); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 554 | #print "C: c<$condition> s<$statement> remain<$remain>\n"; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 555 | last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s)); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 556 | #print "C: push\n"; |
| 557 | push(@chunks, [ $condition, $statement ]); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 558 | } |
| 559 | |
| 560 | return ($level, $linenr, @chunks); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 561 | } |
| 562 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 563 | sub ctx_block_get { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 564 | my ($linenr, $remain, $outer, $open, $close, $off) = @_; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 565 | my $line; |
| 566 | my $start = $linenr - 1; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 567 | my $blk = ''; |
| 568 | my @o; |
| 569 | my @c; |
| 570 | my @res = (); |
| 571 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 572 | my $level = 0; |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 573 | for ($line = $start; $remain > 0; $line++) { |
| 574 | next if ($rawlines[$line] =~ /^-/); |
| 575 | $remain--; |
| 576 | |
| 577 | $blk .= $rawlines[$line]; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 578 | foreach my $c (split(//, $rawlines[$line])) { |
| 579 | ##print "C<$c>L<$level><$open$close>O<$off>\n"; |
| 580 | if ($off > 0) { |
| 581 | $off--; |
| 582 | next; |
| 583 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 584 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 585 | if ($c eq $close && $level > 0) { |
| 586 | $level--; |
| 587 | last if ($level == 0); |
| 588 | } elsif ($c eq $open) { |
| 589 | $level++; |
| 590 | } |
| 591 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 592 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 593 | if (!$outer || $level <= 1) { |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 594 | push(@res, $rawlines[$line]); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 595 | } |
| 596 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 597 | last if ($level == 0); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 598 | } |
| 599 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 600 | return ($level, @res); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 601 | } |
| 602 | sub ctx_block_outer { |
| 603 | my ($linenr, $remain) = @_; |
| 604 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 605 | my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0); |
| 606 | return @r; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 607 | } |
| 608 | sub ctx_block { |
| 609 | my ($linenr, $remain) = @_; |
| 610 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 611 | my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
| 612 | return @r; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 613 | } |
| 614 | sub ctx_statement { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 615 | my ($linenr, $remain, $off) = @_; |
| 616 | |
| 617 | my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off); |
| 618 | return @r; |
| 619 | } |
| 620 | sub ctx_block_level { |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 621 | my ($linenr, $remain) = @_; |
| 622 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 623 | return ctx_block_get($linenr, $remain, 0, '{', '}', 0); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 624 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 625 | sub ctx_statement_level { |
| 626 | my ($linenr, $remain, $off) = @_; |
| 627 | |
| 628 | return ctx_block_get($linenr, $remain, 0, '(', ')', $off); |
| 629 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 630 | |
| 631 | sub ctx_locate_comment { |
| 632 | my ($first_line, $end_line) = @_; |
| 633 | |
| 634 | # Catch a comment on the end of the line itself. |
Andy Whitcroft | beae633 | 2008-07-23 21:28:59 -0700 | [diff] [blame] | 635 | my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 636 | return $current_comment if (defined $current_comment); |
| 637 | |
| 638 | # Look through the context and try and figure out if there is a |
| 639 | # comment. |
| 640 | my $in_comment = 0; |
| 641 | $current_comment = ''; |
| 642 | for (my $linenr = $first_line; $linenr < $end_line; $linenr++) { |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 643 | my $line = $rawlines[$linenr - 1]; |
| 644 | #warn " $line\n"; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 645 | if ($linenr == $first_line and $line =~ m@^.\s*\*@) { |
| 646 | $in_comment = 1; |
| 647 | } |
| 648 | if ($line =~ m@/\*@) { |
| 649 | $in_comment = 1; |
| 650 | } |
| 651 | if (!$in_comment && $current_comment ne '') { |
| 652 | $current_comment = ''; |
| 653 | } |
| 654 | $current_comment .= $line . "\n" if ($in_comment); |
| 655 | if ($line =~ m@\*/@) { |
| 656 | $in_comment = 0; |
| 657 | } |
| 658 | } |
| 659 | |
| 660 | chomp($current_comment); |
| 661 | return($current_comment); |
| 662 | } |
| 663 | sub ctx_has_comment { |
| 664 | my ($first_line, $end_line) = @_; |
| 665 | my $cmt = ctx_locate_comment($first_line, $end_line); |
| 666 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 667 | ##print "LINE: $rawlines[$end_line - 1 ]\n"; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 668 | ##print "CMMT: $cmt\n"; |
| 669 | |
| 670 | return ($cmt ne ''); |
| 671 | } |
| 672 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 673 | sub cat_vet { |
| 674 | my ($vet) = @_; |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 675 | my ($res, $coded); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 676 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 677 | $res = ''; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 678 | while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) { |
| 679 | $res .= $1; |
| 680 | if ($2 ne '') { |
| 681 | $coded = sprintf("^%c", unpack('C', $2) + 64); |
| 682 | $res .= $coded; |
| 683 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 684 | } |
| 685 | $res =~ s/$/\$/; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 686 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 687 | return $res; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 688 | } |
| 689 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 690 | my $av_preprocessor = 0; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 691 | my $av_pending; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 692 | my @av_paren_type; |
| 693 | |
| 694 | sub annotate_reset { |
| 695 | $av_preprocessor = 0; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 696 | $av_pending = '_'; |
| 697 | @av_paren_type = ('E'); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 698 | } |
| 699 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 700 | sub annotate_values { |
| 701 | my ($stream, $type) = @_; |
| 702 | |
| 703 | my $res; |
| 704 | my $cur = $stream; |
| 705 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 706 | print "$stream\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 707 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 708 | while (length($cur)) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 709 | @av_paren_type = ('E') if ($#av_paren_type < 0); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 710 | print " <" . join('', @av_paren_type) . |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 711 | "> <$type> <$av_pending>" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 712 | if ($cur =~ /^(\s+)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 713 | print "WS($1)\n" if ($dbg_values > 1); |
| 714 | if ($1 =~ /\n/ && $av_preprocessor) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 715 | $type = pop(@av_paren_type); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 716 | $av_preprocessor = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 717 | } |
| 718 | |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 719 | } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\))/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 720 | print "DECLARE($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 721 | $type = 'T'; |
| 722 | |
Andy Whitcroft | 389a2fe | 2008-07-23 21:29:05 -0700 | [diff] [blame] | 723 | } elsif ($cur =~ /^($Modifier)\s*/) { |
| 724 | print "MODIFIER($1)\n" if ($dbg_values > 1); |
| 725 | $type = 'T'; |
| 726 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 727 | } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 728 | print "DEFINE($1,$2)\n" if ($dbg_values > 1); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 729 | $av_preprocessor = 1; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 730 | push(@av_paren_type, $type); |
| 731 | if ($2 ne '') { |
| 732 | $av_pending = 'N'; |
| 733 | } |
| 734 | $type = 'E'; |
| 735 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 736 | } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 737 | print "UNDEF($1)\n" if ($dbg_values > 1); |
| 738 | $av_preprocessor = 1; |
| 739 | push(@av_paren_type, $type); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 740 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 741 | } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 742 | print "PRE_START($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 743 | $av_preprocessor = 1; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 744 | |
| 745 | push(@av_paren_type, $type); |
| 746 | push(@av_paren_type, $type); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 747 | $type = 'E'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 748 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 749 | } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 750 | print "PRE_RESTART($1)\n" if ($dbg_values > 1); |
| 751 | $av_preprocessor = 1; |
| 752 | |
| 753 | push(@av_paren_type, $av_paren_type[$#av_paren_type]); |
| 754 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 755 | $type = 'E'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 756 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 757 | } elsif ($cur =~ /^(\#\s*(?:endif))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 758 | print "PRE_END($1)\n" if ($dbg_values > 1); |
| 759 | |
| 760 | $av_preprocessor = 1; |
| 761 | |
| 762 | # Assume all arms of the conditional end as this |
| 763 | # one does, and continue as if the #endif was not here. |
| 764 | pop(@av_paren_type); |
| 765 | push(@av_paren_type, $type); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 766 | $type = 'E'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 767 | |
| 768 | } elsif ($cur =~ /^(\\\n)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 769 | print "PRECONT($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 770 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 771 | } elsif ($cur =~ /^(__attribute__)\s*\(?/o) { |
| 772 | print "ATTR($1)\n" if ($dbg_values > 1); |
| 773 | $av_pending = $type; |
| 774 | $type = 'N'; |
| 775 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 776 | } elsif ($cur =~ /^(sizeof)\s*(\()?/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 777 | print "SIZEOF($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 778 | if (defined $2) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 779 | $av_pending = 'V'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 780 | } |
| 781 | $type = 'N'; |
| 782 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 783 | } elsif ($cur =~ /^(if|while|typeof|__typeof__|for)\b/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 784 | print "COND($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 785 | $av_pending = 'N'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 786 | $type = 'N'; |
| 787 | |
Andy Whitcroft | 6ef9b29 | 2008-07-23 21:28:59 -0700 | [diff] [blame] | 788 | } elsif ($cur =~/^(return|case|else|goto)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 789 | print "KEYWORD($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 790 | $type = 'N'; |
| 791 | |
| 792 | } elsif ($cur =~ /^(\()/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 793 | print "PAREN('$1')\n" if ($dbg_values > 1); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 794 | push(@av_paren_type, $av_pending); |
| 795 | $av_pending = '_'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 796 | $type = 'N'; |
| 797 | |
| 798 | } elsif ($cur =~ /^(\))/o) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 799 | my $new_type = pop(@av_paren_type); |
| 800 | if ($new_type ne '_') { |
| 801 | $type = $new_type; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 802 | print "PAREN('$1') -> $type\n" |
| 803 | if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 804 | } else { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 805 | print "PAREN('$1')\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 806 | } |
| 807 | |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 808 | } elsif ($cur =~ /^($Ident)\s*\(/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 809 | print "FUNC($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | c8cb2ca | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 810 | $type = 'V'; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 811 | $av_pending = 'V'; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 812 | |
| 813 | } elsif ($cur =~ /^($Ident|$Constant)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 814 | print "IDENT($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 815 | $type = 'V'; |
| 816 | |
| 817 | } elsif ($cur =~ /^($Assignment)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 818 | print "ASSIGN($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 819 | $type = 'N'; |
| 820 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 821 | } elsif ($cur =~/^(;|{|})/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 822 | print "END($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 823 | $type = 'E'; |
| 824 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 825 | } elsif ($cur =~ /^(;|\?|:|\[)/o) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 826 | print "CLOSE($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 827 | $type = 'N'; |
| 828 | |
| 829 | } elsif ($cur =~ /^($Operators)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 830 | print "OP($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 831 | if ($1 ne '++' && $1 ne '--') { |
| 832 | $type = 'N'; |
| 833 | } |
| 834 | |
| 835 | } elsif ($cur =~ /(^.)/o) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 836 | print "C($1)\n" if ($dbg_values > 1); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 837 | } |
| 838 | if (defined $1) { |
| 839 | $cur = substr($cur, length($1)); |
| 840 | $res .= $type x length($1); |
| 841 | } |
| 842 | } |
| 843 | |
| 844 | return $res; |
| 845 | } |
| 846 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 847 | sub possible { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 848 | my ($possible, $line) = @_; |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 849 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 850 | print "CHECK<$possible> ($line)\n" if ($dbg_possible > 1); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 851 | if ($possible !~ /^(?:$Storage|$Type|DEFINE_\S+)$/ && |
| 852 | $possible ne 'goto' && $possible ne 'return' && |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 853 | $possible ne 'case' && $possible ne 'else' && |
Andy Whitcroft | d3ddcf4 | 2008-07-23 21:28:58 -0700 | [diff] [blame] | 854 | $possible ne 'asm' && $possible ne '__asm__' && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 855 | $possible !~ /^(typedef|struct|enum)\b/) { |
| 856 | # Check for modifiers. |
| 857 | $possible =~ s/\s*$Storage\s*//g; |
| 858 | $possible =~ s/\s*$Sparse\s*//g; |
| 859 | if ($possible =~ /^\s*$/) { |
| 860 | |
| 861 | } elsif ($possible =~ /\s/) { |
| 862 | $possible =~ s/\s*$Type\s*//g; |
| 863 | warn "MODIFIER: $possible ($line)\n" if ($dbg_possible); |
| 864 | push(@modifierList, $possible); |
| 865 | |
| 866 | } else { |
| 867 | warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible); |
| 868 | push(@typeList, $possible); |
| 869 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 870 | build_types(); |
| 871 | } |
| 872 | } |
| 873 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 874 | my $prefix = ''; |
| 875 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 876 | sub report { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 877 | if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) { |
| 878 | return 0; |
| 879 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 880 | my $line = $prefix . $_[0]; |
| 881 | |
| 882 | $line = (split('\n', $line))[0] . "\n" if ($terse); |
| 883 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 884 | push(our @report, $line); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 885 | |
| 886 | return 1; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 887 | } |
| 888 | sub report_dump { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 889 | our @report; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 890 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 891 | sub ERROR { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 892 | if (report("ERROR: $_[0]\n")) { |
| 893 | our $clean = 0; |
| 894 | our $cnt_error++; |
| 895 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 896 | } |
| 897 | sub WARN { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 898 | if (report("WARNING: $_[0]\n")) { |
| 899 | our $clean = 0; |
| 900 | our $cnt_warn++; |
| 901 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 902 | } |
| 903 | sub CHK { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 904 | if ($check && report("CHECK: $_[0]\n")) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 905 | our $clean = 0; |
| 906 | our $cnt_chk++; |
| 907 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 908 | } |
| 909 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 910 | sub process { |
| 911 | my $filename = shift; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 912 | |
| 913 | my $linenr=0; |
| 914 | my $prevline=""; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 915 | my $prevrawline=""; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 916 | my $stashline=""; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 917 | my $stashrawline=""; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 918 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 919 | my $length; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 920 | my $indent; |
| 921 | my $previndent=0; |
| 922 | my $stashindent=0; |
| 923 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 924 | our $clean = 1; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 925 | my $signoff = 0; |
| 926 | my $is_patch = 0; |
| 927 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 928 | our @report = (); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 929 | our $cnt_lines = 0; |
| 930 | our $cnt_error = 0; |
| 931 | our $cnt_warn = 0; |
| 932 | our $cnt_chk = 0; |
| 933 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 934 | # Trace the real file/line as we go. |
| 935 | my $realfile = ''; |
| 936 | my $realline = 0; |
| 937 | my $realcnt = 0; |
| 938 | my $here = ''; |
| 939 | my $in_comment = 0; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 940 | my $comment_edge = 0; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 941 | my $first_line = 0; |
| 942 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 943 | my $prev_values = 'E'; |
| 944 | |
| 945 | # suppression flags |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 946 | my %suppress_ifbraces; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 947 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 948 | # Pre-scan the patch sanitizing the lines. |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 949 | # Pre-scan the patch looking for any __setup documentation. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 950 | # |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 951 | my @setup_docs = (); |
| 952 | my $setup_docs = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 953 | |
| 954 | sanitise_line_reset(); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 955 | my $line; |
| 956 | foreach my $rawline (@rawlines) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 957 | $linenr++; |
| 958 | $line = $rawline; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 959 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 960 | if ($rawline=~/^\+\+\+\s+(\S+)/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 961 | $setup_docs = 0; |
| 962 | if ($1 =~ m@Documentation/kernel-parameters.txt$@) { |
| 963 | $setup_docs = 1; |
| 964 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 965 | #next; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 966 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 967 | if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { |
| 968 | $realline=$1-1; |
| 969 | if (defined $2) { |
| 970 | $realcnt=$3+1; |
| 971 | } else { |
| 972 | $realcnt=1+1; |
| 973 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 974 | $in_comment = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 975 | |
| 976 | # Guestimate if this is a continuing comment. Run |
| 977 | # the context looking for a comment "edge". If this |
| 978 | # edge is a close comment then we must be in a comment |
| 979 | # at context start. |
| 980 | my $edge; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 981 | for (my $ln = $linenr + 1; $ln < ($linenr + $realcnt); $ln++) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 982 | next if ($line =~ /^-/); |
| 983 | ($edge) = ($rawlines[$ln - 1] =~ m@(/\*|\*/)@); |
| 984 | last if (defined $edge); |
| 985 | } |
| 986 | if (defined $edge && $edge eq '*/') { |
| 987 | $in_comment = 1; |
| 988 | } |
| 989 | |
| 990 | # Guestimate if this is a continuing comment. If this |
| 991 | # is the start of a diff block and this line starts |
| 992 | # ' *' then it is very likely a comment. |
| 993 | if (!defined $edge && |
| 994 | $rawlines[$linenr] =~ m@^.\s* \*(?:\s|$)@) |
| 995 | { |
| 996 | $in_comment = 1; |
| 997 | } |
| 998 | |
| 999 | ##print "COMMENT:$in_comment edge<$edge> $rawline\n"; |
| 1000 | sanitise_line_reset($in_comment); |
| 1001 | |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1002 | } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1003 | # Standardise the strings and chars within the input to |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1004 | # simplify matching -- only bother with positive lines. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1005 | $line = sanitise_line($rawline); |
| 1006 | } |
| 1007 | push(@lines, $line); |
| 1008 | |
| 1009 | if ($realcnt > 1) { |
| 1010 | $realcnt-- if ($line =~ /^(?:\+| |$)/); |
| 1011 | } else { |
| 1012 | $realcnt = 0; |
| 1013 | } |
| 1014 | |
| 1015 | #print "==>$rawline\n"; |
| 1016 | #print "-->$line\n"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1017 | |
| 1018 | if ($setup_docs && $line =~ /^\+/) { |
| 1019 | push(@setup_docs, $line); |
| 1020 | } |
| 1021 | } |
| 1022 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1023 | $prefix = ''; |
| 1024 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1025 | $realcnt = 0; |
| 1026 | $linenr = 0; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1027 | foreach my $line (@lines) { |
| 1028 | $linenr++; |
| 1029 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1030 | my $rawline = $rawlines[$linenr - 1]; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1031 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1032 | #extract the line range in the file after the patch is applied |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1033 | if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) { |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1034 | $is_patch = 1; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1035 | $first_line = $linenr + 1; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1036 | $realline=$1-1; |
| 1037 | if (defined $2) { |
| 1038 | $realcnt=$3+1; |
| 1039 | } else { |
| 1040 | $realcnt=1+1; |
| 1041 | } |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1042 | annotate_reset(); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1043 | $prev_values = 'E'; |
| 1044 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1045 | %suppress_ifbraces = (); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1046 | next; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1047 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1048 | # track the line number as we move through the hunk, note that |
| 1049 | # new versions of GNU diff omit the leading space on completely |
| 1050 | # blank context lines so we need to count that too. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1051 | } elsif ($line =~ /^( |\+|$)/) { |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1052 | $realline++; |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1053 | $realcnt-- if ($realcnt != 0); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1054 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1055 | # Measure the line length and indent. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1056 | ($length, $indent) = line_stats($rawline); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1057 | |
| 1058 | # Track the previous line. |
| 1059 | ($prevline, $stashline) = ($stashline, $line); |
| 1060 | ($previndent, $stashindent) = ($stashindent, $indent); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1061 | ($prevrawline, $stashrawline) = ($stashrawline, $rawline); |
| 1062 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1063 | #warn "line<$line>\n"; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1064 | |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1065 | } elsif ($realcnt == 1) { |
| 1066 | $realcnt--; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1067 | } |
| 1068 | |
| 1069 | #make up the handle for any error we report on this line |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1070 | $prefix = "$filename:$realline: " if ($emacs && $file); |
| 1071 | $prefix = "$filename:$linenr: " if ($emacs && !$file); |
| 1072 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1073 | $here = "#$linenr: " if (!$file); |
| 1074 | $here = "#$realline: " if ($file); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1075 | |
| 1076 | # extract the filename as it passes |
| 1077 | if ($line=~/^\+\+\+\s+(\S+)/) { |
| 1078 | $realfile = $1; |
| 1079 | $realfile =~ s@^[^/]*/@@; |
| 1080 | |
| 1081 | if ($realfile =~ m@include/asm/@) { |
| 1082 | ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n"); |
| 1083 | } |
| 1084 | next; |
| 1085 | } |
| 1086 | |
Randy Dunlap | 389834b | 2007-06-08 13:47:03 -0700 | [diff] [blame] | 1087 | $here .= "FILE: $realfile:$realline:" if ($realcnt != 0); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1088 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1089 | my $hereline = "$here\n$rawline\n"; |
| 1090 | my $herecurr = "$here\n$rawline\n"; |
| 1091 | my $hereprev = "$here\n$prevrawline\n$rawline\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1092 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1093 | $cnt_lines++ if ($realcnt != 0); |
| 1094 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1095 | #check the patch for a signoff: |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1096 | if ($line =~ /^\s*signed-off-by:/i) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1097 | # This is a signoff, if ugly, so do not double report. |
| 1098 | $signoff++; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1099 | if (!($line =~ /^\s*Signed-off-by:/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1100 | WARN("Signed-off-by: is the preferred form\n" . |
| 1101 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1102 | } |
| 1103 | if ($line =~ /^\s*signed-off-by:\S/i) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1104 | WARN("space required after Signed-off-by:\n" . |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1105 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1106 | } |
| 1107 | } |
| 1108 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1109 | # Check for wrappage within a valid hunk of the file |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1110 | if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1111 | ERROR("patch seems to be corrupt (line wrapped?)\n" . |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1112 | $herecurr) if (!$emitted_corrupt++); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1113 | } |
| 1114 | |
| 1115 | # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php |
| 1116 | if (($realfile =~ /^$/ || $line =~ /^\+/) && |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1117 | $rawline !~ m/^$UTF8*$/) { |
| 1118 | my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/); |
| 1119 | |
| 1120 | my $blank = copy_spacing($rawline); |
| 1121 | my $ptr = substr($blank, 0, length($utf8_prefix)) . "^"; |
| 1122 | my $hereptr = "$hereline$ptr\n"; |
| 1123 | |
| 1124 | ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr); |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1125 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1126 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1127 | #ignore lines being removed |
| 1128 | if ($line=~/^-/) {next;} |
| 1129 | |
| 1130 | # check we are in a valid source file if not then ignore this hunk |
| 1131 | next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1132 | |
| 1133 | #trailing whitespace |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1134 | if ($line =~ /^\+.*\015/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1135 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1136 | ERROR("DOS line endings\n" . $herevet); |
| 1137 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1138 | } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) { |
| 1139 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1140 | ERROR("trailing whitespace\n" . $herevet); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1141 | } |
| 1142 | #80 column limit |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1143 | if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ && |
Andy Whitcroft | f4c014c | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1144 | $rawline !~ /^.\s*\*\s*\@$Ident\s/ && |
| 1145 | $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ && |
| 1146 | $length > 80) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1147 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1148 | WARN("line over 80 characters\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1149 | } |
| 1150 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1151 | # check for adding lines without a newline. |
| 1152 | if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) { |
| 1153 | WARN("adding a line without newline at end of file\n" . $herecurr); |
| 1154 | } |
| 1155 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1156 | # check we are in a valid source file *.[hc] if not then ignore this hunk |
| 1157 | next if ($realfile !~ /\.[hc]$/); |
| 1158 | |
| 1159 | # at the beginning of a line any tabs must come first and anything |
| 1160 | # more than 8 must use tabs. |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1161 | if ($rawline =~ /^\+\s* \t\s*\S/ || |
| 1162 | $rawline =~ /^\+\s* \s*/) { |
| 1163 | my $herevet = "$here\n" . cat_vet($rawline) . "\n"; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1164 | ERROR("code indent should use tabs where possible\n" . $herevet); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1165 | } |
| 1166 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1167 | # check for RCS/CVS revision markers |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1168 | if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1169 | WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr); |
| 1170 | } |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1171 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1172 | # Check for potential 'bare' types |
Andy Whitcroft | f5fe35d | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1173 | my ($stat, $cond, $line_nr_next, $remain_next); |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 1174 | if ($realcnt && $line =~ /.\s*\S/) { |
Andy Whitcroft | f5fe35d | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1175 | ($stat, $cond, $line_nr_next, $remain_next) = |
| 1176 | ctx_statement_block($linenr, $realcnt, 0); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1177 | $stat =~ s/\n./\n /g; |
| 1178 | $cond =~ s/\n./\n /g; |
| 1179 | |
| 1180 | my $s = $stat; |
| 1181 | $s =~ s/{.*$//s; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1182 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1183 | # Ignore goto labels. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1184 | if ($s =~ /$Ident:\*$/s) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1185 | |
| 1186 | # Ignore functions being called |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1187 | } elsif ($s =~ /^.\s*$Ident\s*\(/s) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1188 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1189 | # declarations always start with types |
| 1190 | } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))\s*(?:;|=|,|\()/s) { |
| 1191 | my $type = $1; |
| 1192 | $type =~ s/\s+/ /g; |
| 1193 | possible($type, "A:" . $s); |
| 1194 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1195 | # definitions in global scope can only start with types |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1196 | } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b/s) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1197 | possible($1, "B:" . $s); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1198 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1199 | |
| 1200 | # any (foo ... *) is a pointer cast, and foo is a type |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1201 | while ($s =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/sg) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1202 | possible($1, "C:" . $s); |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1203 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1204 | |
| 1205 | # Check for any sort of function declaration. |
| 1206 | # int foo(something bar, other baz); |
| 1207 | # void (*store_gdt)(x86_descr_ptr *); |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1208 | if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1209 | my ($name_len) = length($1); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1210 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1211 | my $ctx = $s; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1212 | substr($ctx, 0, $name_len + 1, ''); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1213 | $ctx =~ s/\)[^\)]*$//; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1214 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1215 | for my $arg (split(/\s*,\s*/, $ctx)) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1216 | if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1217 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1218 | possible($1, "D:" . $s); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1219 | } |
| 1220 | } |
| 1221 | } |
| 1222 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1223 | } |
| 1224 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1225 | # |
| 1226 | # Checks which may be anchored in the context. |
| 1227 | # |
| 1228 | |
| 1229 | # Check for switch () and associated case and default |
| 1230 | # statements should be at the same indent. |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1231 | if ($line=~/\bswitch\s*\(.*\)/) { |
| 1232 | my $err = ''; |
| 1233 | my $sep = ''; |
| 1234 | my @ctx = ctx_block_outer($linenr, $realcnt); |
| 1235 | shift(@ctx); |
| 1236 | for my $ctx (@ctx) { |
| 1237 | my ($clen, $cindent) = line_stats($ctx); |
| 1238 | if ($ctx =~ /^\+\s*(case\s+|default:)/ && |
| 1239 | $indent != $cindent) { |
| 1240 | $err .= "$sep$ctx\n"; |
| 1241 | $sep = ''; |
| 1242 | } else { |
| 1243 | $sep = "[...]\n"; |
| 1244 | } |
| 1245 | } |
| 1246 | if ($err ne '') { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1247 | ERROR("switch and case should be at the same indent\n$hereline$err"); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1248 | } |
| 1249 | } |
Andy Whitcroft | e2a763c | 2008-07-23 21:29:02 -0700 | [diff] [blame] | 1250 | if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g && |
| 1251 | $line !~ /\G(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$/g) { |
| 1252 | ERROR("trailing statements should be on next line\n" . $herecurr); |
| 1253 | } |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1254 | |
| 1255 | # if/while/etc brace do not go on next line, unless defining a do while loop, |
| 1256 | # or if that brace on the next line is for something else |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1257 | if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1258 | my $pre_ctx = "$1$2"; |
| 1259 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1260 | my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1261 | my $ctx_cnt = $realcnt - $#ctx - 1; |
| 1262 | my $ctx = join("\n", @ctx); |
| 1263 | |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1264 | my $ctx_ln = $linenr; |
| 1265 | my $ctx_skip = $realcnt; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1266 | |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1267 | while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt && |
| 1268 | defined $lines[$ctx_ln - 1] && |
| 1269 | $lines[$ctx_ln - 1] =~ /^-/)) { |
| 1270 | ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n"; |
| 1271 | $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1272 | $ctx_ln++; |
| 1273 | } |
Andy Whitcroft | 548596d | 2008-07-23 21:29:01 -0700 | [diff] [blame] | 1274 | |
Andy Whitcroft | 5321016 | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1275 | #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n"; |
| 1276 | #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n"; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1277 | |
| 1278 | if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) { |
| 1279 | ERROR("that open brace { should be on the previous line\n" . |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1280 | "$here\n$ctx\n$lines[$ctx_ln - 1]\n"); |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1281 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1282 | if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ && |
| 1283 | $ctx =~ /\)\s*\;\s*$/ && |
| 1284 | defined $lines[$ctx_ln - 1]) |
| 1285 | { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1286 | my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]); |
| 1287 | if ($nindent > $indent) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1288 | WARN("trailing semicolon indicates no statements, indent implies otherwise\n" . |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1289 | "$here\n$ctx\n$lines[$ctx_ln - 1]\n"); |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1290 | } |
| 1291 | } |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1292 | } |
| 1293 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1294 | # Track the 'values' across context and added lines. |
| 1295 | my $opline = $line; $opline =~ s/^./ /; |
| 1296 | my $curr_values = annotate_values($opline . "\n", $prev_values); |
| 1297 | $curr_values = $prev_values . $curr_values; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1298 | if ($dbg_values) { |
| 1299 | my $outline = $opline; $outline =~ s/\t/ /g; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1300 | print "$linenr > .$outline\n"; |
| 1301 | print "$linenr > $curr_values\n"; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1302 | } |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1303 | $prev_values = substr($curr_values, -1); |
| 1304 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1305 | #ignore lines not being added |
| 1306 | if ($line=~/^[^\+]/) {next;} |
| 1307 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1308 | # TEST: allow direct testing of the type matcher. |
Andy Whitcroft | 7429c69 | 2008-07-23 21:29:06 -0700 | [diff] [blame^] | 1309 | if ($dbg_type) { |
| 1310 | if ($line =~ /^.\s*$Declare\s*$/) { |
| 1311 | ERROR("TEST: is type\n" . $herecurr); |
| 1312 | } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) { |
| 1313 | ERROR("TEST: is not type ($1 is)\n". $herecurr); |
| 1314 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1315 | next; |
| 1316 | } |
| 1317 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1318 | # check for initialisation to aggregates open brace on the next line |
| 1319 | if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ && |
| 1320 | $line =~ /^.\s*{/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1321 | ERROR("that open brace { should be on the previous line\n" . $hereprev); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1322 | } |
| 1323 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1324 | # |
| 1325 | # Checks which are anchored on the added line. |
| 1326 | # |
| 1327 | |
| 1328 | # check for malformed paths in #include statements (uses RAW line) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1329 | if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) { |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1330 | my $path = $1; |
| 1331 | if ($path =~ m{//}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1332 | ERROR("malformed #include filename\n" . |
| 1333 | $herecurr); |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1334 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1335 | } |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1336 | |
| 1337 | # no C99 // comments |
| 1338 | if ($line =~ m{//}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1339 | ERROR("do not use C99 // comments\n" . $herecurr); |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1340 | } |
| 1341 | # Remove C99 comments. |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1342 | $line =~ s@//.*@@; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1343 | $opline =~ s@//.*@@; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1344 | |
| 1345 | #EXPORT_SYMBOL should immediately follow its function closing }. |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1346 | if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) || |
| 1347 | ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) { |
| 1348 | my $name = $1; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1349 | if (($prevline !~ /^}/) && |
| 1350 | ($prevline !~ /^\+}/) && |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1351 | ($prevline !~ /^ }/) && |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1352 | ($prevline !~ /^.DECLARE_$Ident\(\Q$name\E\)/) && |
| 1353 | ($prevline !~ /^.LIST_HEAD\(\Q$name\E\)/) && |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1354 | ($prevline !~ /^.$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(/) && |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1355 | ($prevline !~ /\b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=|\[)/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1356 | WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1357 | } |
| 1358 | } |
| 1359 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1360 | # check for external initialisers. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1361 | if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) { |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1362 | ERROR("do not initialise externals to 0 or NULL\n" . |
| 1363 | $herecurr); |
| 1364 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1365 | # check for static initialisers. |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 1366 | if ($line =~ /\s*static\s.*=\s*(0|NULL|false)\s*;/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1367 | ERROR("do not initialise statics to 0 or NULL\n" . |
| 1368 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1369 | } |
| 1370 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1371 | # check for new typedefs, only function parameters and sparse annotations |
| 1372 | # make sense. |
| 1373 | if ($line =~ /\btypedef\s/ && |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1374 | $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1375 | $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ && |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1376 | $line !~ /\b__bitwise(?:__|)\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1377 | WARN("do not add new typedefs\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1378 | } |
| 1379 | |
| 1380 | # * goes on variable not on type |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1381 | if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1382 | ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" . |
| 1383 | $herecurr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1384 | |
| 1385 | } elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1386 | ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" . |
| 1387 | $herecurr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1388 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1389 | } elsif ($line =~ m{$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1390 | ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" . |
| 1391 | $herecurr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1392 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1393 | } elsif ($line =~ m{$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1394 | ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" . |
| 1395 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1396 | } |
| 1397 | |
| 1398 | # # no BUG() or BUG_ON() |
| 1399 | # if ($line =~ /\b(BUG|BUG_ON)\b/) { |
| 1400 | # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n"; |
| 1401 | # print "$herecurr"; |
| 1402 | # $clean = 0; |
| 1403 | # } |
| 1404 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1405 | if ($line =~ /\bLINUX_VERSION_CODE\b/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1406 | WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1407 | } |
| 1408 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1409 | # printk should use KERN_* levels. Note that follow on printk's on the |
| 1410 | # same line do not need a level, so we use the current block context |
| 1411 | # to try and find and validate the current printk. In summary the current |
| 1412 | # printk includes all preceeding printk's which have no newline on the end. |
| 1413 | # we assume the first bad printk is the one to report. |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1414 | if ($line =~ /\bprintk\((?!KERN_)\s*"/) { |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1415 | my $ok = 0; |
| 1416 | for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) { |
| 1417 | #print "CHECK<$lines[$ln - 1]\n"; |
| 1418 | # we have a preceeding printk if it ends |
| 1419 | # with "\n" ignore it, else it is to blame |
| 1420 | if ($lines[$ln - 1] =~ m{\bprintk\(}) { |
| 1421 | if ($rawlines[$ln - 1] !~ m{\\n"}) { |
| 1422 | $ok = 1; |
| 1423 | } |
| 1424 | last; |
| 1425 | } |
| 1426 | } |
| 1427 | if ($ok == 0) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1428 | WARN("printk() should include KERN_ facility level\n" . $herecurr); |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1429 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1430 | } |
| 1431 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1432 | # function brace can't be on same line, except for #defines of do while, |
| 1433 | # or if closed on same line |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1434 | if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and |
| 1435 | !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1436 | ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1437 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1438 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1439 | # open braces for enum, union and struct go on the same line. |
| 1440 | if ($line =~ /^.\s*{/ && |
| 1441 | $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) { |
| 1442 | ERROR("open brace '{' following $1 go on the same line\n" . $hereprev); |
| 1443 | } |
| 1444 | |
Andy Whitcroft | 8d31cfc | 2008-07-23 21:29:02 -0700 | [diff] [blame] | 1445 | # check for spacing round square brackets; allowed: |
| 1446 | # 1. with a type on the left -- int [] a; |
| 1447 | # 2. at the beginning of a line for slice initialisers -- [0..10] = 5, |
| 1448 | while ($line =~ /(.*?\s)\[/g) { |
| 1449 | my ($where, $prefix) = ($-[1], $1); |
| 1450 | if ($prefix !~ /$Type\s+$/ && |
| 1451 | ($where != 0 || $prefix !~ /^.\s+$/)) { |
| 1452 | ERROR("space prohibited before open square bracket '['\n" . $herecurr); |
| 1453 | } |
| 1454 | } |
| 1455 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1456 | # check for spaces between functions and their parentheses. |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1457 | while ($line =~ /($Ident)\s+\(/g) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1458 | my $name = $1; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1459 | my $ctx_before = substr($line, 0, $-[1]); |
| 1460 | my $ctx = "$ctx_before$name"; |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1461 | |
| 1462 | # Ignore those directives where spaces _are_ permitted. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1463 | if ($name =~ /^(?: |
| 1464 | if|for|while|switch|return|case| |
| 1465 | volatile|__volatile__| |
| 1466 | __attribute__|format|__extension__| |
| 1467 | asm|__asm__)$/x) |
| 1468 | { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1469 | |
| 1470 | # cpp #define statements have non-optional spaces, ie |
| 1471 | # if there is a space between the name and the open |
| 1472 | # parenthesis it is simply not a parameter group. |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1473 | } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1474 | |
| 1475 | # cpp #elif statement condition may start with a ( |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1476 | } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1477 | |
| 1478 | # If this whole things ends with a type its most |
| 1479 | # likely a typedef for a function. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1480 | } elsif ($ctx =~ /$Type$/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1481 | |
| 1482 | } else { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1483 | WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1484 | } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1485 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1486 | # Check operator spacing. |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1487 | if (!($line=~/\#\s*include/)) { |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1488 | my $ops = qr{ |
| 1489 | <<=|>>=|<=|>=|==|!=| |
| 1490 | \+=|-=|\*=|\/=|%=|\^=|\|=|&=| |
| 1491 | =>|->|<<|>>|<|>|=|!|~| |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1492 | &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|% |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1493 | }x; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1494 | my @elements = split(/($ops|;)/, $opline); |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 1495 | my $off = 0; |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1496 | |
| 1497 | my $blank = copy_spacing($opline); |
| 1498 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1499 | for (my $n = 0; $n < $#elements; $n += 2) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1500 | $off += length($elements[$n]); |
| 1501 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1502 | # Pick up the preceeding and succeeding characters. |
| 1503 | my $ca = substr($opline, 0, $off); |
| 1504 | my $cc = ''; |
| 1505 | if (length($opline) >= ($off + length($elements[$n + 1]))) { |
| 1506 | $cc = substr($opline, $off + length($elements[$n + 1])); |
| 1507 | } |
| 1508 | my $cb = "$ca$;$cc"; |
| 1509 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1510 | my $a = ''; |
| 1511 | $a = 'V' if ($elements[$n] ne ''); |
| 1512 | $a = 'W' if ($elements[$n] =~ /\s$/); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1513 | $a = 'C' if ($elements[$n] =~ /$;$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1514 | $a = 'B' if ($elements[$n] =~ /(\[|\()$/); |
| 1515 | $a = 'O' if ($elements[$n] eq ''); |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1516 | $a = 'E' if ($ca =~ /^\s*$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1517 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1518 | my $op = $elements[$n + 1]; |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1519 | |
| 1520 | my $c = ''; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1521 | if (defined $elements[$n + 2]) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1522 | $c = 'V' if ($elements[$n + 2] ne ''); |
| 1523 | $c = 'W' if ($elements[$n + 2] =~ /^\s/); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1524 | $c = 'C' if ($elements[$n + 2] =~ /^$;/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1525 | $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/); |
| 1526 | $c = 'O' if ($elements[$n + 2] eq ''); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1527 | $c = 'E' if ($elements[$n + 2] =~ /\s*\\$/); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1528 | } else { |
| 1529 | $c = 'E'; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1530 | } |
| 1531 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1532 | my $ctx = "${a}x${c}"; |
| 1533 | |
| 1534 | my $at = "(ctx:$ctx)"; |
| 1535 | |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1536 | my $ptr = substr($blank, 0, $off) . "^"; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1537 | my $hereptr = "$hereline$ptr\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1538 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1539 | # Classify operators into binary, unary, or |
| 1540 | # definitions (* only) where they have more |
| 1541 | # than one mode. |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1542 | my $op_type = substr($curr_values, $off + 1, 1); |
| 1543 | my $op_left = substr($curr_values, $off, 1); |
| 1544 | my $is_unary; |
| 1545 | if ($op_type eq 'T') { |
| 1546 | $is_unary = 2; |
| 1547 | } elsif ($op_left eq 'V') { |
| 1548 | $is_unary = 0; |
| 1549 | } else { |
| 1550 | $is_unary = 1; |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1551 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1552 | #if ($op eq '-' || $op eq '&' || $op eq '*') { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1553 | # print "UNARY: <$op_left$op_type $is_unary $a:$op:$c> <$ca:$op:$cc> <$unary_ctx>\n"; |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1554 | #} |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1555 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1556 | # Ignore operators passed as parameters. |
| 1557 | if ($op_type ne 'V' && |
| 1558 | $ca =~ /\s$/ && $cc =~ /^\s*,/) { |
| 1559 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1560 | # # Ignore comments |
| 1561 | # } elsif ($op =~ /^$;+$/) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1562 | |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1563 | # ; should have either the end of line or a space or \ after it |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1564 | } elsif ($op eq ';') { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1565 | if ($ctx !~ /.x[WEBC]/ && |
| 1566 | $cc !~ /^\\/ && $cc !~ /^;/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1567 | ERROR("space required after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1568 | } |
| 1569 | |
| 1570 | # // is a comment |
| 1571 | } elsif ($op eq '//') { |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1572 | |
| 1573 | # -> should have no spaces |
| 1574 | } elsif ($op eq '->') { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1575 | if ($ctx =~ /Wx.|.xW/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1576 | ERROR("spaces prohibited around that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1577 | } |
| 1578 | |
| 1579 | # , must have a space on the right. |
| 1580 | } elsif ($op eq ',') { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1581 | if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1582 | ERROR("space required after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1583 | } |
| 1584 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1585 | # '*' as part of a type definition -- reported already. |
| 1586 | } elsif ($op eq '*' && $is_unary == 2) { |
| 1587 | #warn "'*' is part of type\n"; |
| 1588 | |
| 1589 | # unary operators should have a space before and |
| 1590 | # none after. May be left adjacent to another |
| 1591 | # unary operator, or a cast |
| 1592 | } elsif ($op eq '!' || $op eq '~' || |
| 1593 | ($is_unary && ($op eq '*' || $op eq '-' || $op eq '&'))) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1594 | if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1595 | ERROR("space required before that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1596 | } |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1597 | if ($op eq '*' && $cc =~/\s*const\b/) { |
| 1598 | # A unary '*' may be const |
| 1599 | |
| 1600 | } elsif ($ctx =~ /.xW/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1601 | ERROR("space prohibited after that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1602 | } |
| 1603 | |
| 1604 | # unary ++ and unary -- are allowed no space on one side. |
| 1605 | } elsif ($op eq '++' or $op eq '--') { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1606 | if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) { |
| 1607 | ERROR("space required one side of that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1608 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1609 | if ($ctx =~ /Wx[BE]/ || |
| 1610 | ($ctx =~ /Wx./ && $cc =~ /^;/)) { |
| 1611 | ERROR("space prohibited before that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1612 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1613 | if ($ctx =~ /ExW/) { |
| 1614 | ERROR("space prohibited after that '$op' $at\n" . $hereptr); |
| 1615 | } |
| 1616 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1617 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1618 | # << and >> may either have or not have spaces both sides |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1619 | } elsif ($op eq '<<' or $op eq '>>' or |
| 1620 | $op eq '&' or $op eq '^' or $op eq '|' or |
| 1621 | $op eq '+' or $op eq '-' or |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1622 | $op eq '*' or $op eq '/' or |
| 1623 | $op eq '%') |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1624 | { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1625 | if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1626 | ERROR("need consistent spacing around '$op' $at\n" . |
| 1627 | $hereptr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1628 | } |
| 1629 | |
| 1630 | # All the others need spaces both sides. |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1631 | } elsif ($ctx !~ /[EWC]x[CWE]/) { |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1632 | # Ignore email addresses <foo@bar> |
| 1633 | if (!($op eq '<' && $cb =~ /$;\S+\@\S+>/) && |
| 1634 | !($op eq '>' && $cb =~ /<\S+\@\S+$;/)) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1635 | ERROR("spaces required around that '$op' $at\n" . $hereptr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1636 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1637 | } |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1638 | $off += length($elements[$n + 1]); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1639 | } |
| 1640 | } |
| 1641 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1642 | # check for multiple assignments |
| 1643 | if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) { |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 1644 | CHK("multiple assignments should be avoided\n" . $herecurr); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1645 | } |
| 1646 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1647 | ## # check for multiple declarations, allowing for a function declaration |
| 1648 | ## # continuation. |
| 1649 | ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ && |
| 1650 | ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) { |
| 1651 | ## |
| 1652 | ## # Remove any bracketed sections to ensure we do not |
| 1653 | ## # falsly report the parameters of functions. |
| 1654 | ## my $ln = $line; |
| 1655 | ## while ($ln =~ s/\([^\(\)]*\)//g) { |
| 1656 | ## } |
| 1657 | ## if ($ln =~ /,/) { |
| 1658 | ## WARN("declaring multiple variables together should be avoided\n" . $herecurr); |
| 1659 | ## } |
| 1660 | ## } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1661 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1662 | #need space before brace following if, while, etc |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1663 | if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) || |
| 1664 | $line =~ /do{/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1665 | ERROR("space required before the open brace '{'\n" . $herecurr); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1666 | } |
| 1667 | |
| 1668 | # closing brace should have a space following it when it has anything |
| 1669 | # on the line |
| 1670 | if ($line =~ /}(?!(?:,|;|\)))\S/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1671 | ERROR("space required after that close brace '}'\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1672 | } |
| 1673 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1674 | # check spacing on square brackets |
| 1675 | if ($line =~ /\[\s/ && $line !~ /\[\s*$/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1676 | ERROR("space prohibited after that open square bracket '['\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1677 | } |
| 1678 | if ($line =~ /\s\]/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1679 | ERROR("space prohibited before that close square bracket ']'\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1680 | } |
| 1681 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1682 | # check spacing on parentheses |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 1683 | if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ && |
| 1684 | $line !~ /for\s*\(\s+;/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1685 | ERROR("space prohibited after that open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1686 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1687 | if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1688 | $line !~ /for\s*\(.*;\s+\)/ && |
| 1689 | $line !~ /:\s+\)/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1690 | ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr); |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 1691 | } |
| 1692 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1693 | #goto labels aren't indented, allow a single space however |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1694 | if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1695 | !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1696 | WARN("labels should not be indented\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1697 | } |
| 1698 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1699 | # Return is not a function. |
| 1700 | if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) { |
| 1701 | my $spacing = $1; |
| 1702 | my $value = $2; |
| 1703 | |
| 1704 | # Flatten any parentheses and braces |
Andy Whitcroft | fee61c4 | 2008-07-23 21:28:56 -0700 | [diff] [blame] | 1705 | $value =~ s/\)\(/\) \(/g; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1706 | while ($value =~ s/\([^\(\)]*\)/1/) { |
| 1707 | } |
| 1708 | |
| 1709 | if ($value =~ /^(?:$Ident|-?$Constant)$/) { |
| 1710 | ERROR("return is not a function, parentheses are not required\n" . $herecurr); |
| 1711 | |
| 1712 | } elsif ($spacing !~ /\s+/) { |
| 1713 | ERROR("space required before the open parenthesis '('\n" . $herecurr); |
| 1714 | } |
| 1715 | } |
| 1716 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1717 | # Need a space before open parenthesis after if, while etc |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 1718 | if ($line=~/\b(if|while|for|switch)\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1719 | ERROR("space required before the open parenthesis '('\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1720 | } |
| 1721 | |
Andy Whitcroft | f5fe35d | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1722 | # Check for illegal assignment in if conditional -- and check for trailing |
| 1723 | # statements after the conditional. |
Andy Whitcroft | 5321016 | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1724 | if ($line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 1725 | my ($s, $c) = ($stat, $cond); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1726 | |
| 1727 | if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1728 | ERROR("do not use assignment in if condition\n" . $herecurr); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1729 | } |
| 1730 | |
| 1731 | # Find out what is on the end of the line after the |
| 1732 | # conditional. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1733 | substr($s, 0, length($c), ''); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1734 | $s =~ s/\n.*//g; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1735 | $s =~ s/$;//g; # Remove any comments |
Andy Whitcroft | 5321016 | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1736 | if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ && |
| 1737 | $c !~ /}\s*while\s*/) |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1738 | { |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1739 | ERROR("trailing statements should be on next line\n" . $herecurr); |
| 1740 | } |
| 1741 | } |
| 1742 | |
Andy Whitcroft | f5fe35d | 2008-07-23 21:29:03 -0700 | [diff] [blame] | 1743 | # Check relative indent for conditionals and blocks. |
| 1744 | if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) { |
| 1745 | my ($s, $c) = ($stat, $cond); |
| 1746 | |
| 1747 | substr($s, 0, length($c), ''); |
| 1748 | |
| 1749 | # Make sure we remove the line prefixes as we have |
| 1750 | # none on the first line, and are going to readd them |
| 1751 | # where necessary. |
| 1752 | $s =~ s/\n./\n/gs; |
| 1753 | |
| 1754 | # We want to check the first line inside the block |
| 1755 | # starting at the end of the conditional, so remove: |
| 1756 | # 1) any blank line termination |
| 1757 | # 2) any opening brace { on end of the line |
| 1758 | # 3) any do (...) { |
| 1759 | my $continuation = 0; |
| 1760 | my $check = 0; |
| 1761 | $s =~ s/^.*\bdo\b//; |
| 1762 | $s =~ s/^\s*{//; |
| 1763 | if ($s =~ s/^\s*\\//) { |
| 1764 | $continuation = 1; |
| 1765 | } |
| 1766 | if ($s =~ s/^\s*\n//) { |
| 1767 | $check = 1; |
| 1768 | } |
| 1769 | |
| 1770 | # Also ignore a loop construct at the end of a |
| 1771 | # preprocessor statement. |
| 1772 | if (($prevline =~ /^.\s*#\s*define\s/ || |
| 1773 | $prevline =~ /\\\s*$/) && $continuation == 0) { |
| 1774 | $check = 0; |
| 1775 | } |
| 1776 | |
| 1777 | # Ignore the current line if its is a preprocessor |
| 1778 | # line. |
| 1779 | if ($s =~ /^\s*#\s*/) { |
| 1780 | $check = 0; |
| 1781 | } |
| 1782 | |
| 1783 | my (undef, $sindent) = line_stats("+" . $s); |
| 1784 | |
| 1785 | ##print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s>\n"; |
| 1786 | |
| 1787 | if ($check && (($sindent % 8) != 0 || |
| 1788 | ($sindent <= $indent && $s ne ''))) { |
| 1789 | WARN("suspect code indent for conditional statements\n" . $herecurr); |
| 1790 | } |
| 1791 | } |
| 1792 | |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1793 | # Check for bitwise tests written as boolean |
| 1794 | if ($line =~ / |
| 1795 | (?: |
| 1796 | (?:\[|\(|\&\&|\|\|) |
| 1797 | \s*0[xX][0-9]+\s* |
| 1798 | (?:\&\&|\|\|) |
| 1799 | | |
| 1800 | (?:\&\&|\|\|) |
| 1801 | \s*0[xX][0-9]+\s* |
| 1802 | (?:\&\&|\|\||\)|\]) |
| 1803 | )/x) |
| 1804 | { |
| 1805 | WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr); |
| 1806 | } |
| 1807 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 1808 | # if and else should not have general statements after it |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1809 | if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) { |
| 1810 | my $s = $1; |
| 1811 | $s =~ s/$;//g; # Remove any comments |
| 1812 | if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) { |
| 1813 | ERROR("trailing statements should be on next line\n" . $herecurr); |
| 1814 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1815 | } |
| 1816 | |
| 1817 | # Check for }<nl>else {, these must be at the same |
| 1818 | # indent level to be relevant to each other. |
| 1819 | if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and |
| 1820 | $previndent == $indent) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1821 | ERROR("else should follow close brace '}'\n" . $hereprev); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1822 | } |
| 1823 | |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1824 | if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and |
| 1825 | $previndent == $indent) { |
| 1826 | my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0); |
| 1827 | |
| 1828 | # Find out what is on the end of the line after the |
| 1829 | # conditional. |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1830 | substr($s, 0, length($c), ''); |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 1831 | $s =~ s/\n.*//g; |
| 1832 | |
| 1833 | if ($s =~ /^\s*;/) { |
| 1834 | ERROR("while should follow close brace '}'\n" . $hereprev); |
| 1835 | } |
| 1836 | } |
| 1837 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1838 | #studly caps, commented out until figure out how to distinguish between use of existing and adding new |
| 1839 | # if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) { |
| 1840 | # print "No studly caps, use _\n"; |
| 1841 | # print "$herecurr"; |
| 1842 | # $clean = 0; |
| 1843 | # } |
| 1844 | |
| 1845 | #no spaces allowed after \ in define |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1846 | if ($line=~/\#\s*define.*\\\s$/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1847 | WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1848 | } |
| 1849 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1850 | #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line) |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1851 | if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) { |
| 1852 | my $checkfile = "include/linux/$1.h"; |
| 1853 | if (-f "$root/$checkfile" && $realfile ne $checkfile && |
| 1854 | $1 ne 'irq') |
| 1855 | { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1856 | WARN("Use #include <linux/$1.h> instead of <asm/$1.h>\n" . |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1857 | $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1858 | } |
| 1859 | } |
| 1860 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1861 | # multi-statement macros should be enclosed in a do while loop, grab the |
| 1862 | # first statement and ensure its the whole macro if its not enclosed |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1863 | # in a known good container |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1864 | if ($line =~ /^.\s*\#\s*define\s*$Ident(\()?/) { |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1865 | my $ln = $linenr; |
| 1866 | my $cnt = $realcnt; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1867 | my ($off, $dstat, $dcond, $rest); |
| 1868 | my $ctx = ''; |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1869 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1870 | my $args = defined($1); |
| 1871 | |
| 1872 | # Find the end of the macro and limit our statement |
| 1873 | # search to that. |
| 1874 | while ($cnt > 0 && defined $lines[$ln - 1] && |
| 1875 | $lines[$ln - 1] =~ /^(?:-|..*\\$)/) |
| 1876 | { |
| 1877 | $ctx .= $rawlines[$ln - 1] . "\n"; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 1878 | $cnt-- if ($lines[$ln - 1] !~ /^-/); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1879 | $ln++; |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1880 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1881 | $ctx .= $rawlines[$ln - 1]; |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1882 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1883 | ($dstat, $dcond, $ln, $cnt, $off) = |
| 1884 | ctx_statement_block($linenr, $ln - $linenr + 1, 0); |
| 1885 | #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n"; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 1886 | #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n"; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1887 | |
| 1888 | # Extract the remainder of the define (if any) and |
| 1889 | # rip off surrounding spaces, and trailing \'s. |
| 1890 | $rest = ''; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 1891 | while ($off != 0 || ($cnt > 0 && $rest =~ /(?:^|\\)\s*$/)) { |
| 1892 | #print "ADDING $off <" . substr($lines[$ln - 1], $off) . ">\n"; |
| 1893 | if ($off != 0 || $lines[$ln - 1] !~ /^-/) { |
| 1894 | $rest .= substr($lines[$ln - 1], $off) . "\n"; |
| 1895 | $cnt--; |
| 1896 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1897 | $ln++; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1898 | $off = 0; |
| 1899 | } |
| 1900 | $rest =~ s/\\\n.//g; |
| 1901 | $rest =~ s/^\s*//s; |
| 1902 | $rest =~ s/\s*$//s; |
| 1903 | |
| 1904 | # Clean up the original statement. |
| 1905 | if ($args) { |
| 1906 | substr($dstat, 0, length($dcond), ''); |
| 1907 | } else { |
| 1908 | $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//; |
| 1909 | } |
| 1910 | $dstat =~ s/\\\n.//g; |
| 1911 | $dstat =~ s/^\s*//s; |
| 1912 | $dstat =~ s/\s*$//s; |
| 1913 | |
| 1914 | # Flatten any parentheses and braces |
| 1915 | while ($dstat =~ s/\([^\(\)]*\)/1/) { |
| 1916 | } |
| 1917 | while ($dstat =~ s/\{[^\{\}]*\}/1/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1918 | } |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1919 | |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1920 | my $exceptions = qr{ |
| 1921 | $Declare| |
| 1922 | module_param_named| |
| 1923 | MODULE_PARAM_DESC| |
| 1924 | DECLARE_PER_CPU| |
| 1925 | DEFINE_PER_CPU| |
| 1926 | __typeof__\( |
| 1927 | }x; |
Andy Whitcroft | a3bb97a | 2008-07-23 21:29:00 -0700 | [diff] [blame] | 1928 | #print "REST<$rest>\n"; |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1929 | if ($rest ne '') { |
| 1930 | if ($rest !~ /while\s*\(/ && |
| 1931 | $dstat !~ /$exceptions/) |
| 1932 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1933 | ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n"); |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 1934 | } |
| 1935 | |
| 1936 | } elsif ($ctx !~ /;/) { |
| 1937 | if ($dstat ne '' && |
| 1938 | $dstat !~ /^(?:$Ident|-?$Constant)$/ && |
| 1939 | $dstat !~ /$exceptions/ && |
| 1940 | $dstat =~ /$Operators/) |
| 1941 | { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 1942 | ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n"); |
Andy Whitcroft | d8aaf12 | 2007-06-23 17:16:44 -0700 | [diff] [blame] | 1943 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 1944 | } |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 1945 | } |
| 1946 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1947 | # check for redundant bracing round if etc |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1948 | if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) { |
| 1949 | my ($level, $endln, @chunks) = |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1950 | ctx_statement_full($linenr, $realcnt, 1); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1951 | #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1952 | #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n"; |
| 1953 | if ($#chunks > 0 && $level == 0) { |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1954 | my $allowed = 0; |
| 1955 | my $seen = 0; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1956 | my $herectx = $here . "\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1957 | my $ln = $linenr - 1; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1958 | for my $chunk (@chunks) { |
| 1959 | my ($cond, $block) = @{$chunk}; |
| 1960 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1961 | # If the condition carries leading newlines, then count those as offsets. |
| 1962 | my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s); |
| 1963 | my $offset = statement_rawlines($whitespace) - 1; |
| 1964 | |
| 1965 | #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n"; |
| 1966 | |
| 1967 | # We have looked at and allowed this specific line. |
| 1968 | $suppress_ifbraces{$ln + $offset} = 1; |
| 1969 | |
| 1970 | $herectx .= "$rawlines[$ln + $offset]\n[...]\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1971 | $ln += statement_rawlines($block) - 1; |
| 1972 | |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1973 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1974 | |
| 1975 | $seen++ if ($block =~ /^\s*{/); |
| 1976 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1977 | #print "cond<$cond> block<$block> allowed<$allowed>\n"; |
| 1978 | if (statement_lines($cond) > 1) { |
| 1979 | #print "APW: ALLOWED: cond<$cond>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1980 | $allowed = 1; |
| 1981 | } |
| 1982 | if ($block =~/\b(?:if|for|while)\b/) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1983 | #print "APW: ALLOWED: block<$block>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1984 | $allowed = 1; |
| 1985 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1986 | if (statement_block_size($block) > 1) { |
| 1987 | #print "APW: ALLOWED: lines block<$block>\n"; |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1988 | $allowed = 1; |
| 1989 | } |
| 1990 | } |
| 1991 | if ($seen && !$allowed) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1992 | WARN("braces {} are not necessary for any arm of this statement\n" . $herectx); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1993 | } |
| 1994 | } |
| 1995 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 1996 | if (!defined $suppress_ifbraces{$linenr - 1} && |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 1997 | $line =~ /\b(if|while|for|else)\b/) { |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 1998 | my $allowed = 0; |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 1999 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2000 | # Check the pre-context. |
| 2001 | if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) { |
| 2002 | #print "APW: ALLOWED: pre<$1>\n"; |
| 2003 | $allowed = 1; |
| 2004 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2005 | |
| 2006 | my ($level, $endln, @chunks) = |
| 2007 | ctx_statement_full($linenr, $realcnt, $-[0]); |
| 2008 | |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2009 | # Check the condition. |
| 2010 | my ($cond, $block) = @{$chunks[0]}; |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2011 | #print "CHECKING<$linenr> cond<$cond> block<$block>\n"; |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2012 | if (defined $cond) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2013 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2014 | } |
| 2015 | if (statement_lines($cond) > 1) { |
| 2016 | #print "APW: ALLOWED: cond<$cond>\n"; |
| 2017 | $allowed = 1; |
| 2018 | } |
| 2019 | if ($block =~/\b(?:if|for|while)\b/) { |
| 2020 | #print "APW: ALLOWED: block<$block>\n"; |
| 2021 | $allowed = 1; |
| 2022 | } |
| 2023 | if (statement_block_size($block) > 1) { |
| 2024 | #print "APW: ALLOWED: lines block<$block>\n"; |
| 2025 | $allowed = 1; |
| 2026 | } |
| 2027 | # Check the post-context. |
| 2028 | if (defined $chunks[1]) { |
| 2029 | my ($cond, $block) = @{$chunks[1]}; |
| 2030 | if (defined $cond) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2031 | substr($block, 0, length($cond), ''); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2032 | } |
Andy Whitcroft | cf65504 | 2008-03-04 14:28:20 -0800 | [diff] [blame] | 2033 | if ($block =~ /^\s*\{/) { |
| 2034 | #print "APW: ALLOWED: chunk-1 block<$block>\n"; |
| 2035 | $allowed = 1; |
| 2036 | } |
| 2037 | } |
| 2038 | if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) { |
| 2039 | my $herectx = $here . "\n";; |
| 2040 | my $end = $linenr + statement_rawlines($block) - 1; |
| 2041 | |
| 2042 | for (my $ln = $linenr - 1; $ln < $end; $ln++) { |
| 2043 | $herectx .= $rawlines[$ln] . "\n";; |
| 2044 | } |
| 2045 | |
| 2046 | WARN("braces {} are not necessary for single statement blocks\n" . $herectx); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2047 | } |
| 2048 | } |
| 2049 | |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2050 | # don't include deprecated include files (uses RAW line) |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2051 | for my $inc (@dep_includes) { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2052 | if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2053 | ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2054 | } |
| 2055 | } |
| 2056 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2057 | # don't use deprecated functions |
| 2058 | for my $func (@dep_functions) { |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2059 | if ($line =~ /\b$func\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2060 | ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2061 | } |
| 2062 | } |
| 2063 | |
| 2064 | # no volatiles please |
Andy Whitcroft | 6c72ffa | 2007-10-18 03:05:08 -0700 | [diff] [blame] | 2065 | my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b}; |
| 2066 | if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2067 | WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2068 | } |
| 2069 | |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2070 | # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated |
| 2071 | if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) { |
| 2072 | ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr); |
| 2073 | } |
| 2074 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2075 | # warn about #if 0 |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2076 | if ($line =~ /^.\s*\#\s*if\s+0\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2077 | CHK("if this code is redundant consider removing it\n" . |
| 2078 | $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2079 | } |
| 2080 | |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2081 | # check for needless kfree() checks |
| 2082 | if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { |
| 2083 | my $expr = $1; |
| 2084 | if ($line =~ /\bkfree\(\Q$expr\E\);/) { |
Wolfram Sang | 3c23214 | 2008-07-23 21:29:05 -0700 | [diff] [blame] | 2085 | WARN("kfree(NULL) is safe this check is probably not required\n" . $hereprev); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2086 | } |
| 2087 | } |
Greg Kroah-Hartman | 4c432a8 | 2008-07-23 21:29:04 -0700 | [diff] [blame] | 2088 | # check for needless usb_free_urb() checks |
| 2089 | if ($prevline =~ /\bif\s*\(([^\)]*)\)/) { |
| 2090 | my $expr = $1; |
| 2091 | if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) { |
| 2092 | WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev); |
| 2093 | } |
| 2094 | } |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2095 | |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2096 | # warn about #ifdefs in C files |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2097 | # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) { |
Andy Whitcroft | 00df344f | 2007-06-08 13:47:06 -0700 | [diff] [blame] | 2098 | # print "#ifdef in C files should be avoided\n"; |
| 2099 | # print "$herecurr"; |
| 2100 | # $clean = 0; |
| 2101 | # } |
| 2102 | |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2103 | # warn about spacing in #ifdefs |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2104 | if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) { |
Andy Whitcroft | 22f2a2e | 2007-08-10 13:01:03 -0700 | [diff] [blame] | 2105 | ERROR("exactly one space required after that #$1\n" . $herecurr); |
| 2106 | } |
| 2107 | |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2108 | # check for spinlock_t definitions without a comment. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2109 | if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ || |
| 2110 | $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) { |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2111 | my $which = $1; |
| 2112 | if (!ctx_has_comment($first_line, $linenr)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2113 | CHK("$1 definition without comment\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2114 | } |
| 2115 | } |
| 2116 | # check for memory barriers without a comment. |
| 2117 | if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) { |
| 2118 | if (!ctx_has_comment($first_line, $linenr)) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2119 | CHK("memory barrier without comment\n" . $herecurr); |
Andy Whitcroft | 4a0df2e | 2007-06-08 13:46:39 -0700 | [diff] [blame] | 2120 | } |
| 2121 | } |
| 2122 | # check of hardware specific defines |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2123 | if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2124 | CHK("architecture specific defines should be avoided\n" . $herecurr); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2125 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2126 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2127 | # check the location of the inline attribute, that it is between |
| 2128 | # storage class and type. |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2129 | if ($line =~ /\b$Type\s+$Inline\b/ || |
| 2130 | $line =~ /\b$Inline\s+$Storage\b/) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2131 | ERROR("inline keyword should sit between storage class and type\n" . $herecurr); |
| 2132 | } |
| 2133 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2134 | # Check for __inline__ and __inline, prefer inline |
| 2135 | if ($line =~ /\b(__inline__|__inline)\b/) { |
| 2136 | WARN("plain inline is preferred over $1\n" . $herecurr); |
| 2137 | } |
| 2138 | |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2139 | # check for new externs in .c files. |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2140 | if ($realfile =~ /\.c$/ && defined $stat && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2141 | $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s) |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2142 | { |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2143 | my $function_name = $1; |
| 2144 | my $paren_space = $2; |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2145 | |
| 2146 | my $s = $stat; |
| 2147 | if (defined $cond) { |
| 2148 | substr($s, 0, length($cond), ''); |
| 2149 | } |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2150 | if ($s =~ /^\s*;/ && |
| 2151 | $function_name ne 'uninitialized_var') |
| 2152 | { |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2153 | WARN("externs should be avoided in .c files\n" . $herecurr); |
| 2154 | } |
| 2155 | |
| 2156 | if ($paren_space =~ /\n/) { |
| 2157 | WARN("arguments for function declarations should follow identifier\n" . $herecurr); |
| 2158 | } |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 2159 | |
| 2160 | } elsif ($realfile =~ /\.c$/ && defined $stat && |
| 2161 | $stat =~ /^.\s*extern\s+/) |
| 2162 | { |
| 2163 | WARN("externs should be avoided in .c files\n" . $herecurr); |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2164 | } |
| 2165 | |
| 2166 | # checks for new __setup's |
| 2167 | if ($rawline =~ /\b__setup\("([^"]*)"/) { |
| 2168 | my $name = $1; |
| 2169 | |
| 2170 | if (!grep(/$name/, @setup_docs)) { |
| 2171 | CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr); |
| 2172 | } |
Andy Whitcroft | 653d487 | 2007-06-23 17:16:34 -0700 | [diff] [blame] | 2173 | } |
Andy Whitcroft | 9c0ca6f | 2007-10-16 23:29:38 -0700 | [diff] [blame] | 2174 | |
| 2175 | # check for pointless casting of kmalloc return |
| 2176 | if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) { |
| 2177 | WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr); |
| 2178 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2179 | |
| 2180 | # check for gcc specific __FUNCTION__ |
| 2181 | if ($line =~ /__FUNCTION__/) { |
| 2182 | WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr); |
| 2183 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2184 | |
| 2185 | # check for semaphores used as mutexes |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2186 | if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2187 | WARN("mutexes are preferred for single holder semaphores\n" . $herecurr); |
| 2188 | } |
| 2189 | # check for semaphores used as mutexes |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2190 | if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) { |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2191 | WARN("consider using a completion\n" . $herecurr); |
| 2192 | } |
| 2193 | # recommend strict_strto* over simple_strto* |
| 2194 | if ($line =~ /\bsimple_(strto.*?)\s*\(/) { |
| 2195 | WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr); |
| 2196 | } |
Michael Ellerman | f3db663 | 2008-07-23 21:28:57 -0700 | [diff] [blame] | 2197 | # check for __initcall(), use device_initcall() explicitly please |
| 2198 | if ($line =~ /^.\s*__initcall\s*\(/) { |
| 2199 | WARN("please use device_initcall() instead of __initcall()\n" . $herecurr); |
| 2200 | } |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2201 | |
| 2202 | # use of NR_CPUS is usually wrong |
| 2203 | # ignore definitions of NR_CPUS and usage to define arrays as likely right |
| 2204 | if ($line =~ /\bNR_CPUS\b/ && |
Andy Whitcroft | c45dcab | 2008-06-05 22:46:01 -0700 | [diff] [blame] | 2205 | $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ && |
| 2206 | $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ && |
Andy Whitcroft | 171ae1a | 2008-04-29 00:59:32 -0700 | [diff] [blame] | 2207 | $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ && |
| 2208 | $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ && |
| 2209 | $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/) |
Andy Whitcroft | 773647a | 2008-03-28 14:15:58 -0700 | [diff] [blame] | 2210 | { |
| 2211 | WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr); |
| 2212 | } |
Andy Whitcroft | 9c9ba34 | 2008-04-29 00:59:33 -0700 | [diff] [blame] | 2213 | |
| 2214 | # check for %L{u,d,i} in strings |
| 2215 | my $string; |
| 2216 | while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) { |
| 2217 | $string = substr($rawline, $-[1], $+[1] - $-[1]); |
| 2218 | if ($string =~ /(?<!%)%L[udi]/) { |
| 2219 | WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr); |
| 2220 | last; |
| 2221 | } |
| 2222 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2223 | } |
| 2224 | |
| 2225 | # If we have no input at all, then there is nothing to report on |
| 2226 | # so just keep quiet. |
| 2227 | if ($#rawlines == -1) { |
| 2228 | exit(0); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2229 | } |
| 2230 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2231 | # In mailback mode only produce a report in the negative, for |
| 2232 | # things that appear to be patches. |
| 2233 | if ($mailback && ($clean == 1 || !$is_patch)) { |
| 2234 | exit(0); |
| 2235 | } |
| 2236 | |
| 2237 | # This is not a patch, and we are are in 'no-patch' mode so |
| 2238 | # just keep quiet. |
| 2239 | if (!$chk_patch && !$is_patch) { |
| 2240 | exit(0); |
| 2241 | } |
| 2242 | |
| 2243 | if (!$is_patch) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2244 | ERROR("Does not appear to be a unified-diff format patch\n"); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2245 | } |
| 2246 | if ($is_patch && $chk_signoff && $signoff == 0) { |
Andy Whitcroft | de7d4f0 | 2007-07-15 23:37:22 -0700 | [diff] [blame] | 2247 | ERROR("Missing Signed-off-by: line(s)\n"); |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2248 | } |
| 2249 | |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2250 | print report_dump(); |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2251 | if ($summary && !($clean == 1 && $quiet == 1)) { |
| 2252 | print "$filename " if ($summary_file); |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2253 | print "total: $cnt_error errors, $cnt_warn warnings, " . |
| 2254 | (($check)? "$cnt_chk checks, " : "") . |
| 2255 | "$cnt_lines lines checked\n"; |
| 2256 | print "\n" if ($quiet == 0); |
Andy Whitcroft | f0a594c | 2007-07-19 01:48:34 -0700 | [diff] [blame] | 2257 | } |
Andy Whitcroft | 8905a67 | 2007-11-28 16:21:06 -0800 | [diff] [blame] | 2258 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2259 | if ($clean == 1 && $quiet == 0) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2260 | print "$vname has no obvious style problems and is ready for submission.\n" |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2261 | } |
| 2262 | if ($clean == 0 && $quiet == 0) { |
Andy Whitcroft | c2fdda0 | 2008-02-08 04:20:54 -0800 | [diff] [blame] | 2263 | print "$vname has style problems, please review. If any of these errors\n"; |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2264 | print "are false positives report them to the maintainer, see\n"; |
| 2265 | print "CHECKPATCH in MAINTAINERS.\n"; |
| 2266 | } |
Andy Whitcroft | 13214ad | 2008-02-08 04:22:03 -0800 | [diff] [blame] | 2267 | |
Andy Whitcroft | 0a920b5b | 2007-06-01 00:46:48 -0700 | [diff] [blame] | 2268 | return $clean; |
| 2269 | } |