commit | 4cde8cf63bdbe9fd0118222d27ff5aaabed339fb | [log] [tgz] |
---|---|---|
author | Mike Frysinger <vapier@google.com> | Thu Sep 15 22:17:31 2016 +0000 |
committer | android-build-merger <android-build-merger@google.com> | Thu Sep 15 22:17:31 2016 +0000 |
tree | 5b6469dab7e6dd9b7af526ce27c6cd0e4a65fddc | |
parent | 2de284c04e618e58beddb1d7150698b487dd63e9 [diff] | |
parent | 36fcda2e19959ff7512e4898ca33fc04a95e3c25 [diff] |
Merge "pylint: add a tools path config for it" am: 77bdd31937 am: b843789dff am: 84f9b5dc07 am: 36fcda2e19 Change-Id: Ie9467e49b4e2554298963bd5a4baf74b269a9185
This repo holds hooks that get run by repo during the upload phase. They perform various checks automatically such as running linters on your code.
Note: Currently all hooks are disabled by default. Each repo must explicitly turn on any hook it wishes to enforce.
Normally these execute automatically when you run repo upload
. If you want to run them by hand, you can execute pre-upload.py
directly. By default, that will scan the active repo and process all commits that haven't yet been merged. See its help for more info.
Sometimes you might want to bypass the upload checks. While this is strongly discouraged (often failures you add will affect others and block them too), sometimes there are valid reasons for this. You can simply use the option --no-verify
when running repo upload
to skip all upload checks. This will skip all checks and not just specific ones. It should be used only after having run & evaluated the upload output previously.
There are two types of config files:
The merging of these config files control the hooks/checks that get run when running repo upload
.
These are the manifest-wide defaults and can be located in two places:
.repo/manifests/GLOBAL-PREUPLOAD.cfg
: The manifest git repo. Simply check this in to the manifest git repo and you're done.GLOBAL-PREUPLOAD.cfg
: The top level of the repo checkout. For manifests that don't have a project checked out at the top level, you can use repo's <copyfile>
directive.These config files will be loaded first before stacking PREUPLOAD.cfg
settings on top.
This file are checked in the top of a specific git repository. Stacking them in subdirectories (to try and override parent settings) is not supported.
[Hook Scripts] name = script --with args ${PREUPLOAD_FILES} [Builtin Hooks] cpplint = true [Builtin Hooks Options] cpplint = --filter=-x ${PREUPLOAD_FILES} [Tool Paths] clang-format = /usr/bin/clang-format
Hooks are executed in the top directory of the git repository. All paths should generally be relative to that point.
A few environment variables are set so scripts don't need to discover things.
REPO_PROJECT
: The name of the project. e.g. platform/tools/repohooks
REPO_PATH
: The path to the project relative to the root. e.g. tools/repohooks
REPO_REMOTE
: The remote git URL. e.g. https://android.googlesource.com/platform/tools/repohooks
PREUPLOAD_COMMIT
: The commit that is currently being checked. e.g. 1f89dce0468448fa36f632d2fc52175cd6940a91
[Hook Scripts]
This section allows for completely arbitrary hooks to run on a per-repo basis.
The key can be any name (as long as the syntax is valid), as can the program that is executed.
[Hook Scripts] my_first_hook = program --gogog ${PREUPLOAD_FILES} another_hook = funtimes --i-need "some space" ${PREUPLOAD_FILES} some_fish = linter --ate-a-cat ${PREUPLOAD_FILES} some_cat = formatter --cat-commit ${PREUPLOAD_COMMIT} some_dog = tool --no-cat-in-commit-message ${PREUPLOAD_COMMIT_MESSAGE}
[Builtin Hooks]
This section allows for turning on common/builtin hooks. There are a bunch of canned hooks already included geared towards AOSP style guidelines.
checkpatch
: Run commits through the Linux kernel's checkpatch.pl
script.clang_format
: Run git-clang-format against the commit. The default style is file
.commit_msg_bug_field
: Require a valid Bug:
line.commit_msg_changeid_field
: Require a valid Change-Id:
Gerrit line.commit_msg_test_field
: Require a Test:
line.cpplint
: Run through the cpplint tool (for C++ code).gofmt
: Run Go code through gofmt
.jsonlint
: Verify JSON code is sane.pylint
: Run Python code through pylint
.xmllint
: Run XML code through xmllint
.Note: Builtin hooks tend to match specific filenames (e.g. .json
). If no files match in a specific commit, then the hook will be skipped for that commit.
[Builtin Hooks] # Turn on cpplint checking. cpplint = true # Turn off gofmt checking. gofmt = false
[Builtin Hooks Options]
Used to customize the behavior of specific [Builtin Hooks]
. Any arguments set here will be passed directly to the linter in question. This will completely override any existing default options, so be sure to include everything you need (especially ${PREUPLOAD_FILES}
-- see below).
Quoting is handled naturally. i.e. use "a b c"
to pass an argument with whitespace.
A few keywords are recognized to pass down settings. These are not environment variables, but are expanded inline. Files with whitespace and such will be expanded correctly via argument positions, so do not try to force your own quote handling.
${PREUPLOAD_FILES}
: List of files to operate on.${PREUPLOAD_COMMIT}
: Commit hash.${PREUPLOAD_COMMIT_MESSAGE}
: Commit message.[Builtin Hooks Options] # Pass more filter args to cpplint. cpplint = --filter=-x ${PREUPLOAD_FILES}
[Tool Paths]
Some builtin hooks need to call external executables to work correctly. By default it will call those tools from the user's $PATH
, but the paths of those executables can be overridden through [Tool Paths]
. This is helpful to provide consistent behavior for developers across different OS and Linux distros/versions. The following tools are recognized:
clang-format
: used for the clang_format
builtin hook.cpplint
: used for the cpplint
builtin hook.git-clang-format
: used for the clang_format
builtin hook.pylint
: used for the pylint
builtin hook.Some variables are available to make it easier to handle OS differences. These are automatically expanded for you:
${REPO_ROOT}
: The absolute path of the root of the repo checkout.${BUILD_OS}
: The string darwin-x86
for macOS and the string linux-x86
for Linux/x86.[Tool Paths] # Pass absolute paths. clang-format = /usr/bin/clang-format # Or paths relative to the top of the git project. clang-format = prebuilts/bin/clang-format # Or paths relative to the repo root. clang-format = ${REPO_ROOT}/prebuilts/clang/host/${BUILD_OS}/clang-stable/bin/clang-format
These are notes for people updating the pre-upload.py
hook itself:
pre-upload.py
script is loaded and exec-ed in its own context. The only entry-point that matters is main
.rh/hooks.py
. Be sure to keep the list up-to-date with the documentation in this file.pylint
should support per-repo pylintrc files.pylint
needs to know what other modules exist locally to verify their API. We can support this case by doing a full checkout of the repo in a temp dir, but this can slow things down a lot. Will need to consider a PREUPLOAD.cfg
knob.pylint
tool to the AOSP manifest and use that local copy instead of relying on the version that is in $PATH.clang-format
diffs each change against the current working tree. This works well if a single change is being uploaded, but if multiple commits are being uploaded, later commits in the chain will have false positives..cc
and .py
and .xml
.clang-check
: Runs static analyzers against code.