commit | 73d4b4627297ffcc42b04f851b35e890eaef77a3 | [log] [tgz] |
---|---|---|
author | Kirit <kirit@google.com> | Fri Jun 16 19:52:50 2023 +0000 |
committer | Kirit <kirit@google.com> | Fri Jun 16 21:54:04 2023 +0000 |
tree | efb478c7662c7dcd6832184fe8ffdeeae4382100 | |
parent | 2aa0fa5666fee773ec83529ef35271524d6aa6bb [diff] |
checkstyle: add io to ImportOrder Checkstyle and google-java-format currently disagree on the order of io. imports. This change enforces alphabetical ordering in accordance with https://source.android.com/docs/setup/contribute/code-style#order-import-statements Test: manual testing that `repo upload .` passes checks with the correct io import order. Fixes: b/287664151 Change-Id: Iae54e301ea5a96711896c24632231a2c776606df
Checkstyle is used by developers to validate Java code style and formatting, and can be run as part of the pre-upload hooks.
It can be invoked in two ways.
checkstyle.py -f FILE [FILE ...]
checkstyle.py
A development tool to help programmers write Java code that adheres to a coding standard.
Git-lint is a tool to run lint checks on only files changed in the latest commit.
To run checkstyle as part of the pre-upload hooks, add the following line to your PREUPLOAD.cfg
:
checkstyle_hook = ${REPO_ROOT}/prebuilts/checkstyle/checkstyle.py --sha ${PREUPLOAD_COMMIT}
Note that checkstyle does not always agree with clang-format, and so it's best to only have one enabled for Java.
In .clang-format
add the following to disable format checking and correcting for Java:
--- Language: Java DisableFormat: true SortIncludes: false ---
In some versions of clang-format, DisableFormat
doesn't stop the sorting of includes. So to fully disable clang-format from doing anything for Java files, both options are needed.