[zlib] Clean-up BUILD.gn no-chromium-code config rules

The zlib no-chromium-code rule leached into some build sub-rules where
they are not actually needed: undo that.

Rule configs and source_sets have separate sections dealing with Intel
vs Arm: keep them separate (no if's with else's), white-space helps.

Minor ordering changes: generally it's sources first, defines && deps,
then configs. Use that order most everywhere. Special case: "warnings"
do not quite fit. Leave them till last which matches their comments as
a side-effect.

Bug: 1072308
Change-Id: I2cbce82f165fad4d594b93a5169d6bc57585717e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156228
Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org>
Auto-Submit: Noel Gordon <noel@chromium.org>
Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#760669}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 3d38d588dfd76b6861f4fc4dfff878fb90222665
1 file changed