Gitiles
Code Review Sign In
android-review.linaro.org / platform / external / toolchain-utils / 0a0912727ddaf0bae67a4b8c0fd41aa5d57b00b5
commit0a0912727ddaf0bae67a4b8c0fd41aa5d57b00b5[log] [tgz]
authorBob Haarman <inglorion@chromium.org>Wed Jan 31 23:16:07 2024 +0000
committerChromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Feb 01 18:48:06 2024 +0000
tree985bc9cd7ea05a8143a985c35a17245349c94731
parentc2b9e7a4b98906464c89062c3e9d755e7919963a [diff]
rust_uprev: refactor create_ebuild() to take strings instead of a path

create_ebuild() used to take a path to an ebuild file to copy and a
pkgatom which it would split and use to compute the new ebuild path
from. This change refactors create_ebuild() to take the ebuild's
category and name as separate strings (to avoid having to split
strings), and computes both the path to the source ebuild and the
path to the ebuild to be created (to avoid the inconsistency of
computing one but requiring the other to be passed in). This
refactor will be built upon by an upcoming refactor of
create_rust_uprev(), for which it is convenient not to have to
compute the source ebuild path before calling create_ebuild().

BUG=b:322348600
TEST=presubmit

Change-Id: I000e45423e7e33b110d60bd04a59c9f2863597b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5255378
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Bob Haarman <inglorion@chromium.org>
Commit-Queue: Bob Haarman <inglorion@chromium.org>
2 files changed
tree: 985bc9cd7ea05a8143a985c35a17245349c94731
  1. afdo_metadata/
  2. afdo_redaction/
  3. afdo_tools/
  4. bestflags/
  5. binary_search_tool/
  6. compiler_wrapper/
  7. contrib/
  8. cros_utils/
  9. crosperf/
  10. cwp/
  11. debug_info_test/
  12. go/
  13. llvm_extra/
  14. llvm_tools/
  15. pgo_tools/
  16. pgo_tools_rust/
  17. rust-analyzer-chromiumos-wrapper/
  18. rust_tools/
  19. seccomp_tools/
  20. toolchain_utils_githooks/
  21. upstream_workon/
  22. .gitignore
  23. android_merge_from_upstream.sh
  24. auto_delete_nightly_test_data.py
  25. build_chromeos.py
  26. build_tc.py
  27. buildbot_test_toolchains.py
  28. check_portable_toolchains.py
  29. chromiumos_image_diff.py
  30. compiler-test.sh
  31. crate_ebuild_help.py
  32. DIR_METADATA
  33. file_lock_machine.py
  34. file_lock_machine_test.py
  35. image_chromeos.py
  36. LICENSE
  37. lock_machine.py
  38. make_root_writable.py
  39. OWNERS
  40. OWNERS.toolchain
  41. PRESUBMIT.cfg
  42. pyrun
  43. README.chromium
  44. README.md
  45. remote_test.py
  46. run_tests_for.py
  47. tc_enter_chroot.py
  48. update_telemetry_defaults.py
README.md

toolchain-utils

Various utilities used by the ChromeOS toolchain team.

Note

To run Python scripts in this directory, first run:

export PYTHONPATH=$(readlink -f .):$PYTHONPATH

from this directory.

Then you can run any script.

To get help on any script, type in python <script> --help, or refer to the header of the script for more information.