commit 371f6e18e544bc8170970eaa256a4450c9183334
author Ethan Nicholas <ethannicholas@google.com> Tue May 04 14:30:02 2021 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue May 04 19:25:25 2021 +0000
tree f2d54bf99b8c63336518b4cf386ce579adb28b99
parent 4fd6d0cea85171a7f16142b5d381ca6e81c0fc09

Refactored SkSL function creation and error handling

This breaks up the giant IRGenerator::convertFunction method into more-
manageable chunks, moves the functionality into FunctionDeclaration,
and funnels the DSL through it so it receives the same error checking.

Change-Id: Icf2ac650ab3d5276d8c0134062a4e7e220f9bf32
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/402778
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: John Stiles <johnstiles@google.com>

gn/sksl.gni

diff --git a/gn/sksl.gni b/gn/sksl.gni
index ad9a00d..266e8ff 100644
--- a/gn/sksl.gni
+++ b/gn/sksl.gni
@@ -132,6 +132,7 @@
   "$_src/sksl/ir/SkSLForStatement.h",
   "$_src/sksl/ir/SkSLFunctionCall.cpp",
   "$_src/sksl/ir/SkSLFunctionCall.h",
+  "$_src/sksl/ir/SkSLFunctionDeclaration.cpp",
   "$_src/sksl/ir/SkSLFunctionDeclaration.h",
   "$_src/sksl/ir/SkSLFunctionDefinition.h",
   "$_src/sksl/ir/SkSLFunctionPrototype.h",