commit 241e2c497945a93117ce42ebc2a555e3871ca716
author Pierre LALET <pierre.lalet@cea.fr> Wed Apr 27 16:41:43 2016 +0200
committer Pierre LALET <pierre.lalet@cea.fr> Wed Apr 27 16:46:36 2016 +0200
tree 3811012cfe80db245040e88fdc3899ee91591201
parent fa299812a0878dc7c8c747b82f92531bcc7656e6

Code cleanup / optimization

scapy/ansmachine.py

diff --git a/scapy/ansmachine.py b/scapy/ansmachine.py
index 2a90adc..d73bd42 100644
--- a/scapy/ansmachine.py
+++ b/scapy/ansmachine.py
@@ -68,13 +68,13 @@
     def parse_all_options(self, mode, kargs):
         sniffopt = {}
         sendopt = {}
-        for k in kargs.keys():            
+        for k in kargs.keys():  # use .keys(): kargs is modified in the loop
             if k in self.sniff_options_list:
                 sniffopt[k] = kargs[k]
             if k in self.send_options_list:
                 sendopt[k] = kargs[k]
             if k in self.sniff_options_list+self.send_options_list:
-                del(kargs[k])
+                del kargs[k]
         if mode != 2 or kargs:
             if mode == 1:
                 self.optam0 = kargs