| commit | fa446e592c8729df5a3e1158caf2337574fa4a8f | [log] [tgz] |
|---|---|---|
| author | Primiano Tucci <primiano@google.com> | Thu May 16 03:42:09 2024 +0100 |
| committer | Steve Golton <stevegolton@google.com> | Thu May 16 11:56:45 2024 +0000 |
| tree | 8bb69dab27ab990c2f62dc406700123b511f4d19 | |
| parent | 444bb44f0712aeb12d6ab546035811d4541a8f93 [diff] |
ui: Fix Wasm interop calls with pointers > 2GB - We recently bumped the Wasm max memory from 2GB->4GB in aosp/3018909. - That can cause some heap pointers to be >2GB. - Sometimes heap pointers are passed to wasm_bridge.ts:onReply() when they are HeapBuffered buffers for RPC replies. - By default the Wasm bindings map uint32 to JS numbers. If the uint32 is > 2GB the called function sees a negative argument on the JS side. - The fix is to triple-shift (>>> 0) which converts the negative number into the corresponding uint32 positive one. - That in turn would manifest as slicing the wrong address of the buffer when figuring out the boundaries of the RPC reply buffer on the JS side, breaking the RPC sequence. Bug: 332083475 Change-Id: I61005a442ae2322e4db2499812828053bb936104 (cherry picked from commit 8cac0c1697db9594dbbc5c0ff720b47d5b1aa77f)
Perfetto is a production-grade open-source stack for performance instrumentation and trace analysis. It offers services and libraries and for recording system-level and app-level traces, native + java heap profiling, a library for analyzing traces using SQL and a web-based UI to visualize and explore multi-GB traces.
See https://perfetto.dev/docs or the /docs/ directory for documentation.