Gitiles
Code Review Sign In
android-review.linaro.org / platform / external / google-breakpad / de040fa25de948e71cef9c035ba152fa75bfe0ec
commitde040fa25de948e71cef9c035ba152fa75bfe0ec[log] [tgz]
authorBen Wagner <bungeman@chromium.org>Mon Apr 24 23:41:28 2023 -0400
committerJoshua Peraza <jperaza@chromium.org>Fri Apr 28 18:35:40 2023 +0000
tree47ae4f32d12a026559bceeb6bb99a7dee1c726bf
parent68f5a4d11a2703f76b9c4312a4a3df699cef41d8 [diff]
minidump-2-core: Use exception context for crashed thread

Use the exception record's context for the crashed thread instead of
the thread's own context. For the crashed thread the thread's own
context is the state inside the exception handler. Using it would not
result in the expected stack trace from the time of the crash.

This change aligns the behavior of minidump-2-core with the behavior of
minidump_stackwalk.

Bug: google-breakpad:885
Change-Id: I5cd3e9d39807308491b64fcd335f5f85b1dcd084
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/4473128
Reviewed-by: Joshua Peraza <jperaza@google.com>
Reviewed-by: Joshua Peraza <jperaza@chromium.org>
1 file changed
tree: 47ae4f32d12a026559bceeb6bb99a7dee1c726bf
  1. .github/
  2. android/
  3. autotools/
  4. docs/
  5. m4/
  6. src/
  7. .clang-format
  8. .gitignore
  9. aclocal.m4
  10. appveyor.yml
  11. AUTHORS
  12. breakpad-client.pc.in
  13. breakpad.pc.in
  14. ChangeLog
  15. codereview.settings
  16. configure
  17. configure.ac
  18. default.xml
  19. DEPS
  20. DIR_METADATA
  21. INSTALL
  22. LICENSE
  23. Makefile.am
  24. Makefile.in
  25. NEWS
  26. OWNERS
  27. README.ANDROID
  28. README.md
README.md

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from main)

  1. First, download depot_tools and ensure that they’re in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad

  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
cd src

  4. Build the source.

    ./configure && make

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check

  6. Optionally, install the built libraries

    make install

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.