Gitiles
Code Review Sign In
android-review.linaro.org / platform / external / google-breakpad / 0c816d2d127525f489b30ce101653a6c4478b516
commit0c816d2d127525f489b30ce101653a6c4478b516[log] [tgz]
authorGeorge Burgess IV <gbiv@google.com>Mon Jun 27 13:11:00 2022 -0700
committerMike Frysinger <vapier@chromium.org>Mon Jun 27 20:59:02 2022 +0000
treec0c56b73e6067a1984f88d1ffe7480cebb075ce4
parenta8e8a695919679c9aac83541b01953ee9f2439dd [diff]
module_unittest: fix use-after-free

`Construct.FunctionsWithSameAddress` started failing at ff5892c5. It
looks like the cause of this is in the calls to
`generate_duplicate_function`:

```
generate_duplicate_function("_without_form");
generate_duplicate_function("_and_void");
```

`generate_duplicate_function` directly calls `new
Module::Function(...);`, which stores the `StringView` it's given.
`generate_duplicate_function` currently takes a `const
string &`; in the above statements, these strings get `free()`d at the
`;`.

Making the parameter a `StringView` means the `Module::Function` will
store pointers to the string literal, which lives for the whole program.

All calls to `generate_duplicate_function` are given literals.

Bug: b:235999011
Change-Id: Ied04c1307a2467b9816a83f0c4d84d47779ec610
Reviewed-on: https://chromium-review.googlesource.com/c/breakpad/breakpad/+/3726855
Reviewed-by: Mike Frysinger <vapier@chromium.org>
1 file changed
tree: c0c56b73e6067a1984f88d1ffe7480cebb075ce4
  1. .github/
  2. android/
  3. autotools/
  4. docs/
  5. m4/
  6. src/
  7. .clang-format
  8. .gitignore
  9. aclocal.m4
  10. appveyor.yml
  11. AUTHORS
  12. breakpad-client.pc.in
  13. breakpad.pc.in
  14. ChangeLog
  15. codereview.settings
  16. configure
  17. configure.ac
  18. default.xml
  19. DEPS
  20. DIR_METADATA
  21. INSTALL
  22. LICENSE
  23. Makefile.am
  24. Makefile.in
  25. NEWS
  26. OWNERS
  27. README.ANDROID
  28. README.md
README.md

Breakpad

Breakpad is a set of client and server components which implement a crash-reporting system.

Getting started (from main)

  1. First, download depot_tools and ensure that they’re in your PATH.

  2. Create a new directory for checking out the source code (it must be named breakpad).

    mkdir breakpad && cd breakpad

  3. Run the fetch tool from depot_tools to download all the source repos.

    fetch breakpad
cd src

  4. Build the source.

    ./configure && make

    You can also cd to another directory and run configure from there to build outside the source tree.

    This will build the processor tools (src/processor/minidump_stackwalk, src/processor/minidump_dump, etc), and when building on Linux it will also build the client libraries and some tools (src/tools/linux/dump_syms/dump_syms, src/tools/linux/md2core/minidump-2-core, etc).

  5. Optionally, run tests.

    make check

  6. Optionally, install the built libraries

    make install

If you need to reconfigure your build be sure to run make distclean first.

To update an existing checkout to a newer revision, you can git pull as usual, but then you should run gclient sync to ensure that the dependent repos are up-to-date.

To request change review

  1. Follow the steps above to get the source and build it.

  2. Make changes. Build and test your changes. For core code like processor use methods above. For linux/mac/windows, there are test targets in each project file.

  3. Commit your changes to your local repo and upload them to the server. http://dev.chromium.org/developers/contributing-code e.g. git commit ... && git cl upload ... You will be prompted for credential and a description.

  4. At https://chromium-review.googlesource.com/ you'll find your issue listed; click on it, then “Add reviewer”, and enter in the code reviewer. Depending on your settings, you may not see an email, but the reviewer has been notified with google-breakpad-dev@googlegroups.com always CC’d.