Rename the variable 'quality' to 'brotli_quality'
Right now the quality is only used in the brotli compressor. And it
would be ambiguous if we add another compressor in the future; since the
compressors may have different interpretion on the quality value.
Test: unit tests pass; run bsdiff
Change-Id: I23af06a135b2b47df5209171f7db0773ac02a326
diff --git a/bsdiff_arguments_unittest.cc b/bsdiff_arguments_unittest.cc
index 412b8e9..51e1038 100644
--- a/bsdiff_arguments_unittest.cc
+++ b/bsdiff_arguments_unittest.cc
@@ -40,13 +40,13 @@
TEST(BsdiffArgumentsTest, ParseQualityTest) {
int quality;
- EXPECT_TRUE(BsdiffArguments::ParseQuality("9", &quality));
+ EXPECT_TRUE(BsdiffArguments::ParseQuality("9", &quality, 0, 11));
EXPECT_EQ(9, quality);
// Check the out of range quality values.
- EXPECT_FALSE(BsdiffArguments::ParseQuality("30", &quality));
- EXPECT_FALSE(BsdiffArguments::ParseQuality("1234567890", &quality));
- EXPECT_FALSE(BsdiffArguments::ParseQuality("aabb", &quality));
+ EXPECT_FALSE(BsdiffArguments::ParseQuality("30", &quality, 0, 11));
+ EXPECT_FALSE(BsdiffArguments::ParseQuality("1234567890", &quality, 0, 1000));
+ EXPECT_FALSE(BsdiffArguments::ParseQuality("aabb", &quality, 0, 1000));
}
TEST(BsdiffArgumentsTest, ParseMinLengthTest) {
@@ -80,7 +80,7 @@
TEST(BsdiffArgumentsTest, ParseArgumentsSmokeTest) {
std::vector<const char*> args = {"bsdiff", "--format=bsdf2", "--type=brotli",
- "--quality=9", "--minlen=12"};
+ "--brotli_quality=9", "--minlen=12"};
BsdiffArguments arguments;
EXPECT_TRUE(
@@ -88,7 +88,7 @@
EXPECT_EQ(BsdiffFormat::kBsdf2, arguments.format());
EXPECT_EQ(CompressorType::kBrotli, arguments.compressor_type());
- EXPECT_EQ(9, arguments.compression_quality());
+ EXPECT_EQ(9, arguments.brotli_quality());
EXPECT_EQ(12, arguments.min_length());
}