Gitiles
Code Review Sign In
android-review.linaro.org / linaro-art / art-build-scripts / a642ec1b360497acb591cb1416fb164d9bba2138
commita642ec1b360497acb591cb1416fb164d9bba2138[log] [tgz]
authorArtem Serov <artem.serov@linaro.org>Wed Mar 16 09:28:31 2022 +0000
committerArtem Serov <artem.serov@linaro.org>Wed Mar 16 09:37:26 2022 +0000
tree24c183a0f8a09ee9458821086c5faaa832eef78a
parent8d26558f1ee0e9c094cc28edf7b3a7d1881cf15f [diff]
Fix the --gdb option on target.

utils_run.sh were expecting the --gdb option to be defined and
to be 'false' for target tests (it was undefined).

Test: test_art_target.sh --64bit
      --single-test 530-checker-peel-unroll

Test: test_art_target.sh --64bit --gdb --gdb-dex2oat
      --single-test 530-checker-peel-unroll

Test: test_art_target.sh --64bit --optimizing

Change-Id: Ibee315588da2d1df7548e10f35a9b1148109da37
1 file changed
tree: 24c183a0f8a09ee9458821086c5faaa832eef78a
  1. benchmarks/
  2. devices/
  3. jenkins/
  4. perf/
  5. tests/
  6. utils/
  7. .gitignore
  8. generate_compdb.sh
  9. NOTICE
  10. presubmit.sh
  11. README.md
README.md

art-build-scripts

Contents:

  • Overview
  • Requirements
  • Directory Structure
  • Guidelines

Overview

The art-build-scripts are part of a stable/tip checkout. All scripts work for both Tip and Stable. The scripts follow the Google Shell Style Guide, plus following additions:

  • All scripts use set -o nounset (done by default in utils.sh).
  • Constant variables used in the same script are in lower_case.
  • Constant variables used across scripts or picked up from environment are in UPPER_CASE.

Requirements

  1. bash 4.2+

Note: you don't need to have shellcheck installed, presubmit.sh will download it if necessary.

Guidelines

  • All executable scripts should have a main() function.
  • All executable scripts should take options (at least -h and -v) in arguments_parser().
  • All executable scripts have a usage() (-h or --help) that tells how the script should be used.
  • All helper scripts are not executable.
  • All scripts should include at least utils.sh, which
    • sets global shell options like set -o nounset and,
    • enables coloured logging for interactive sessions (not jenkins).
  • All scripts and changes should be checked by running ./presubmit.sh.