tree d1a11b7f5e46881dd01c6203f31cc36a2e266151
parent 5b2639d59afe0a30e1b955b23c52ee9099888058
author Jean Delvare <jdelvare@suse.de> 1238609489 -0500
committer James Bottomley <James.Bottomley@HansenPartnership.com> 1238768594 -0500

[SCSI] libiscsi: fix iscsi pool error path

Le lundi 30 mars 2009, Chris Wright a écrit :
> q->queue could be ERR_PTR(-ENOMEM) which will break unwinding
> on error.  Make iscsi_pool_free more defensive.
>

Making the freeing of q->queue dependent on q->pool being set looks
really weird (although it is correct at the moment. But this seems
to be fixable in a much simpler way.

With the benefit that only the error case is slowed down. In both
cases we have a problem if q->queue contains an error value but it's
not -ENOMEM. Apparently this can't happen today, but it doesn't feel
right to assume this will always be true. Maybe it's the right time
to fix this as well.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>